From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [alsa-devel] Regression in next with codec unload and      snd_soc_component_get/put
Date: Fri, 09 Aug 2019 10:23:42 +0200
Message-ID: <s5hv9v6hhm9.wl-tiwai@suse.de>
References: <20190809070003.GA52127@atomide.com>
        <s5hwofmhkbs.wl-tiwai@suse.de>
        <20190809074643.GB52127@atomide.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20190809074643.GB52127@atomide.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Tony Lindgren <tony@atomide.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
List-Id: alsa-devel@alsa-project.org

On Fri, 09 Aug 2019 09:46:43 +0200,
Tony Lindgren wrote:
> 
> * Takashi Iwai <tiwai@suse.de> [190809 07:25]:
> > On Fri, 09 Aug 2019 09:00:03 +0200,
> > Tony Lindgren wrote:
> > > 
> > > Hi,
> > > 
> > > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> > > snd_soc_component_get/put()") causes a regression where trying
> > > to rmmod a codec driver fails with module is in use error after
> > > rmmod of snd-soc-audio-graph-card for example.
> > > 
> > > Any ideas what goes wrong there?
> > 
> > There is an obvious typo: soc_cleanup_component() should call
> > snd_soc_component_module_put_when_remove() instead of *_close().
> 
> Making that change locally seems to fix it thanks.

... and it was already fixed in the later commit 0e36f36b04e7
"ASoC: soc-core: fix module_put() warning in soc_cleanup_component".


Takashi