From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 3/3] pcm_file: in case of failed write clear file buffer variables Date: Wed, 03 Jul 2019 14:23:34 +0200 Message-ID: References: <1561987518-2828-1-git-send-email-amiartus@de.adit-jv.com> <1561987518-2828-4-git-send-email-amiartus@de.adit-jv.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6085FF800C5 for ; Wed, 3 Jul 2019 14:23:35 +0200 (CEST) In-Reply-To: <1561987518-2828-4-git-send-email-amiartus@de.adit-jv.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Adam Miartus Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Mon, 01 Jul 2019 15:25:18 +0200, Adam Miartus wrote: > > previously, in case of failed write to output file, error is returned > from snd_pcm_writei/read APIs, user could run pcm_drain as fallback and > encounter an assert, since drain would try to write remaining file > buffer to a file > > if failed to write to output file in first place, it makes sense to clear > current internal pmc_file file buffer variables > > Signed-off-by: Adam Miartus > Reviewed-by: Timo Wischer Applied, thanks. Takashi