From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Alexander Stein <alexander.stein@systec-electronic.com>
Subject: Re: [PATCH 1/1] ASoC: core: Do not print an actual error when deferring probe
Date: Wed, 18 May 2016 18:57:50 +0200 [thread overview]
Message-ID: <s5hvb2bz4kx.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160518162154.GP8104@sirena.org.uk>
On Wed, 18 May 2016 18:21:54 +0200,
Mark Brown wrote:
>
> On Wed, May 18, 2016 at 05:50:50PM +0200, Alexander Stein wrote:
>
> > My first idea was to use dev_dbg() but that actualy remove that message at
> > all, unless dynamic debug is used, so I went with dev_notice. It's still
> > there, but does not clobber quiet boot log, nor some sophisticated kernel log
> > parser as journalctl which prints errors in red color.
>
> It's just shifting the problem around... it sounds like for your use
> case suppressing the messages until we finish kernel boot would deal
> with most of the issue in a far more general fashion.
It comes to the question whether this message must be shown verbosely
as an error at all. EPROBE_DEFER is usually a mechanism for the
delayed probe, and it doesn't indicate an error per se. dev_err() is,
OTOH, for real errors that have to be notified to user inevitably.
That's why "quiet" boot option still shows it.
Takashi
next prev parent reply other threads:[~2016-05-18 16:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 13:41 [PATCH 1/1] ASoC: core: Do not print an actual error when deferring probe Alexander Stein
2016-05-18 14:25 ` Ricard Wanderlof
2016-05-18 15:08 ` Mark Brown
2016-05-18 15:18 ` Alexander Stein
2016-05-18 15:28 ` Mark Brown
2016-05-18 15:50 ` Alexander Stein
2016-05-18 16:21 ` Mark Brown
2016-05-18 16:57 ` Takashi Iwai [this message]
2016-05-18 17:20 ` Mark Brown
2016-05-18 19:33 ` Takashi Iwai
2016-05-19 6:28 ` Alexander Stein
2016-05-19 6:53 ` Takashi Iwai
2016-05-19 10:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hvb2bz4kx.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alexander.stein@systec-electronic.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox