From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH] ASoC: Intel: Skylake: Fix kbuild dependency
Date: Fri, 18 Mar 2016 18:34:04 +0100 [thread overview]
Message-ID: <s5hvb4j3d2r.wl-tiwai@suse.de> (raw)
In-Reply-To: <1458312023-20167-1-git-send-email-vinod.koul@intel.com>
On Fri, 18 Mar 2016 15:40:23 +0100,
Vinod Koul wrote:
>
> The Skylake driver selects SND_HDA_I915 which causes kbuild to spew warning:
>
> warning: (SND_SOC_INTEL_SKYLAKE) selects SND_HDA_I915 which has unmet direct dependencies
> (SOUND && !M68K && !UML && SND && DRM_I915 && SND_HDA_CORE)
>
> The SND_HDA_I915 should not be selected so drop that.
>
> Reported-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
> ---
> sound/soc/intel/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index b3e6c2300457..1120f4f4d011 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -163,7 +163,6 @@ config SND_SOC_INTEL_SKYLAKE
> tristate
> select SND_HDA_EXT_CORE
> select SND_SOC_TOPOLOGY
> - select SND_HDA_I915
> select SND_SOC_INTEL_SST
>
> config SND_SOC_INTEL_SKL_RT286_MACH
> --
> 1.9.1
>
prev parent reply other threads:[~2016-03-18 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 14:40 [PATCH] ASoC: Intel: Skylake: Fix kbuild dependency Vinod Koul
2016-03-18 17:34 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hvb4j3d2r.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).