From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] define more missing types for non-Linux
Date: Thu, 03 Mar 2016 10:55:01 +0100
Message-ID: <s5hvb53rimi.wl-tiwai@suse.de>
References: <56D010C4.3000804@ladisch.de>
 <1456758321-2256-1-git-send-email-tk@giga.or.at>
 <1456758321-2256-2-git-send-email-tk@giga.or.at>
 <s5h8u23xzt1.wl-tiwai@suse.de>
 <20160302221454.GC8492@danbala.tuwien.ac.at>
 <sfid-H20160303-103215-+045.37-1@spamfilter.osbf.lua>
 <s5h60x3sy97.wl-tiwai@suse.de>
 <20160303095041.GG8492@danbala.tuwien.ac.at>
 <s5hwppjriol.wl-tiwai@suse.de>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 53E992619D0
 for <alsa-devel@alsa-project.org>; Thu,  3 Mar 2016 10:55:02 +0100 (CET)
In-Reply-To: <s5hwppjriol.wl-tiwai@suse.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Thomas Klausner <tk@giga.or.at>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

On Thu, 03 Mar 2016 10:53:46 +0100,
Takashi Iwai wrote:
> 
> On Thu, 03 Mar 2016 10:50:41 +0100,
> Thomas Klausner wrote:
> > 
> > On Thu, Mar 03, 2016 at 10:32:04AM +0100, Takashi Iwai wrote:
> > > Can we put this in include/type_compat.h or something like that, and
> > > include it in #else block of #ifdef __linux__?
> > > 
> > > As a bonus, the EBADFD definition can also go to there, too.
> > 
> > Sure, see attached.
> >  Thomas
> > >From c68bfda4e5198b50b32937de669155afb423d726 Mon Sep 17 00:00:00 2001
> > From: Thomas Klausner <wiz@NetBSD.org>
> > Date: Wed, 2 Mar 2016 23:11:54 +0100
> > Subject: [PATCH] Define some types if missing.
> > 
> > For portability with non-Linux.
> > 
> > Include Linux headers on Linux only.
> > ---
> >  include/local.h       |  6 ++---
> >  include/type_compat.h | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 69 insertions(+), 3 deletions(-)
> >  create mode 100644 include/type_compat.h
> 
> You need to add it in include/Makefile.am, too.
> Otherwise it'll slip from the tarball.

Oh, also it'd be good if you give your sign-off, too.
For user-space, I accept the patches without sign-off as long as they
are trivial enough.  But this kind of change is preferred with a
proper sign off, of course.


thanks,

Takashi