From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v5 05/10] ALSA: core: selection of audio_tstamp type and accuracy reports
Date: Mon, 09 Feb 2015 16:16:42 +0100 [thread overview]
Message-ID: <s5hvbjbru79.wl-tiwai@suse.de> (raw)
In-Reply-To: <1423259759-4100-6-git-send-email-pierre-louis.bossart@linux.intel.com>
At Fri, 6 Feb 2015 15:55:54 -0600,
Pierre-Louis Bossart wrote:
>
> +static inline void snd_pcm_pack_audio_tstamp_report(__u32 *data, __u32 *accuracy,
> + struct snd_pcm_audio_tstamp_report *report)
Put const to report argument.
> +{
> + u32 tmp;
> +
> + tmp = report->accuracy_report;
> + tmp <<= 4;
> + tmp |= report->actual_type;
> + tmp <<= 1;
> + tmp |= report->valid;
> +
> + *data |= (tmp << 16);
Isn't there any zero-clear?
Takashi
next prev parent reply other threads:[~2015-02-09 15:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 21:55 [PATCH v5 00/10] audio timestamping evolutions Pierre-Louis Bossart
2015-02-06 21:55 ` [PATCH v5 01/10] ALSA: core: don't override timestamp unconditionally Pierre-Louis Bossart
2015-02-09 15:05 ` Takashi Iwai
2015-02-06 21:55 ` [PATCH v5 02/10] ALSA: core: allow for trigger_tstamp snapshot in .trigger Pierre-Louis Bossart
2015-02-09 15:06 ` Takashi Iwai
2015-02-06 21:55 ` [PATCH v5 03/10] ALSA: hda: read trigger_timestamp immediately after starting DMA Pierre-Louis Bossart
2015-02-09 15:06 ` Takashi Iwai
2015-02-06 21:55 ` [PATCH v5 04/10] ALSA: usb: update trigger timestamp on first non-zero URB submitted Pierre-Louis Bossart
2015-02-09 15:06 ` Takashi Iwai
2015-02-06 21:55 ` [PATCH v5 05/10] ALSA: core: selection of audio_tstamp type and accuracy reports Pierre-Louis Bossart
2015-02-09 15:16 ` Takashi Iwai [this message]
2015-02-06 21:55 ` [PATCH v5 06/10] ALSA: core: pass audio tstamp config from userspace Pierre-Louis Bossart
2015-02-09 15:08 ` Takashi Iwai
2015-02-06 21:55 ` [PATCH v5 07/10] ALSA: core: pass audio tstamp config from userspace in compat mode Pierre-Louis Bossart
2015-02-06 21:55 ` [PATCH v5 08/10] ALSA: core: replace .wall_clock by .get_time_info Pierre-Louis Bossart
2015-02-09 15:19 ` Takashi Iwai
2015-02-06 21:55 ` [PATCH v5 09/10] ALSA: hda: replace .wallclock " Pierre-Louis Bossart
2015-02-06 21:55 ` [PATCH v5 10/10] ALSA: bump PCM protocol to 2.0.13 Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hvbjbru79.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox