From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ASoC: tlv320aic3x: Fix data delay configuration Date: Fri, 30 Jan 2015 15:18:42 +0100 Message-ID: References: <1422621751-30484-1-git-send-email-peter.ujfalusi@ti.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id CA8A5260440 for ; Fri, 30 Jan 2015 15:18:45 +0100 (CET) In-Reply-To: <1422621751-30484-1-git-send-email-peter.ujfalusi@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Peter Ujfalusi Cc: pavel@ucw.cz, alsa-devel@alsa-project.org, Mark Brown , Liam Girdwood , Jarkko Nikula List-Id: alsa-devel@alsa-project.org At Fri, 30 Jan 2015 14:42:31 +0200, Peter Ujfalusi wrote: > > Fix the issue introduced by: > 368494093354 ASoC: tlv320aic3x: Add TDM support Please put "Fixes:" tag in such a case. I guess we'll have a chance to send the last pull request for 3.19 in the next week. If we miss it, we'll have to mark this with Cc to stable. Takashi > > The CTRLC register were not receiving the correct delay configuration, > which will corrupt DSP_A audio mode. > > Reported-by: Pavel Machek > Signed-off-by: Peter Ujfalusi > --- > Hi, > > most of my boards are using DSP_B or I2S mode... This is why this is slipped. > > Peter > > sound/soc/codecs/tlv320aic3x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c > index a78ad361f494..07603d142923 100644 > --- a/sound/soc/codecs/tlv320aic3x.c > +++ b/sound/soc/codecs/tlv320aic3x.c > @@ -1046,7 +1046,7 @@ static int aic3x_prepare(struct snd_pcm_substream *substream, > delay += aic3x->tdm_delay; > > /* Configure data delay */ > - snd_soc_write(codec, AIC3X_ASD_INTF_CTRLC, aic3x->tdm_delay); > + snd_soc_write(codec, AIC3X_ASD_INTF_CTRLC, delay); > > return 0; > } > -- > 2.2.2 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >