From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 1/9] ALSA: pcm_params: Remove unused add/sub functions Date: Tue, 30 Dec 2014 16:49:17 +0100 Message-ID: References: <1419878506-28684-1-git-send-email-lars@metafoo.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 8FDD4260672 for ; Tue, 30 Dec 2014 16:49:17 +0100 (CET) In-Reply-To: <1419878506-28684-1-git-send-email-lars@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Lars-Peter Clausen Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Mon, 29 Dec 2014 19:41:38 +0100, Lars-Peter Clausen wrote: > > Those two functions are not used anywhere and also their name is a bit to > generic to be in a global header, so remove them. > > Signed-off-by: Lars-Peter Clausen Thanks, applied all 9 patches. But the patch 3 was applied to for-linus branch for 3.19-rc, as it's an obvious fix. The rest are targeted for 3.20. Takashi > --- > include/sound/pcm_params.h | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/include/sound/pcm_params.h b/include/sound/pcm_params.h > index 6b1c78f..15760f5 100644 > --- a/include/sound/pcm_params.h > +++ b/include/sound/pcm_params.h > @@ -325,20 +325,6 @@ static inline int snd_interval_eq(const struct snd_interval *i1, const struct sn > i1->max == i2->max && i1->openmax == i2->openmax; > } > > -static inline unsigned int add(unsigned int a, unsigned int b) > -{ > - if (a >= UINT_MAX - b) > - return UINT_MAX; > - return a + b; > -} > - > -static inline unsigned int sub(unsigned int a, unsigned int b) > -{ > - if (a > b) > - return a - b; > - return 0; > -} > - > #define params_access(p) ((__force snd_pcm_access_t)\ > snd_mask_min(hw_param_mask_c((p), SNDRV_PCM_HW_PARAM_ACCESS))) > #define params_format(p) ((__force snd_pcm_format_t)\ > -- > 1.8.0 >