From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
xiangxiao <xiaoxiang@xiaomi.com>
Subject: Re: [PATCH] ASoC: add data field into snd_soc_jack_gpio
Date: Mon, 24 Feb 2014 10:26:33 +0100 [thread overview]
Message-ID: <s5hvbw4yi7q.wl%tiwai@suse.de> (raw)
In-Reply-To: <20140224012840.GP25940@sirena.org.uk>
At Mon, 24 Feb 2014 10:28:40 +0900,
Mark Brown wrote:
>
> On Sun, Feb 23, 2014 at 02:40:44PM +0800, xiangxiao wrote:
> > so callback could get the context data as needed
>
> > Change-Id: I5542613ccf9881deb672e71d0f0c4f603ad761fd
>
> Applied, thanks, but as I said for your previous version of this
> upstream submissions shouldn't have Change-Id, that is to do with your
> internal review system.
Yep, also please write your name in sign-off line in a standard way
at the next time, too (usually either "Firstname Surname <mail>").
Takashi
prev parent reply other threads:[~2014-02-24 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 6:40 [PATCH] ASoC: add data field into snd_soc_jack_gpio xiangxiao
2014-02-24 1:28 ` Mark Brown
2014-02-24 9:26 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hvbw4yi7q.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=xiaoxiang@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox