From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B4B5C433EF for ; Tue, 12 Apr 2022 09:45:15 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B3C3F175F; Tue, 12 Apr 2022 11:44:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B3C3F175F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1649756713; bh=CIIlc8f7vUPgkEwWcsy2dIl57zin2qbQbdM8dA+/l+w=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AwAuqI5NQGRcflMm3D3R2yS15l1dRRjqEN4iLNdkVGbGyrfaUYzbAhIeBt+4tAs3r yWN3TDqoQNIhlCUaPUrLlRCgrDBlkWBH6Vj6e5Up1oYM++rubWmDeTKDvU6+BVSBys Hl8fBymdg9QYVz0skS3WfgrmeluZjR3wqkkHHO4Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 551B8F80134; Tue, 12 Apr 2022 11:44:23 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 84A5CF8011C; Tue, 12 Apr 2022 11:44:21 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5690AF8011C for ; Tue, 12 Apr 2022 11:44:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5690AF8011C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="0rPJ1bo4"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="UmeVgtzn" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id D7FEA1F856; Tue, 12 Apr 2022 09:44:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1649756654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dLptHK6KtYX6UZvI/elziZLSvz95fWcFPoAEGowc2Uo=; b=0rPJ1bo42dEqTeD7PHM5bjmB3YHG75DUMmsRGiMujdzN1l5YFArlYWX6aE0DcaQTwno3dh z5+DrLdqB7iVL+h+YgXSIYK1FBMYo6Rni7u/OukE0AK9tWQnTBCqcN9PwQgkN6BVEjcmfZ sAsKdqtAiGSTmntkog4uxAl5oRoE7sA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1649756654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dLptHK6KtYX6UZvI/elziZLSvz95fWcFPoAEGowc2Uo=; b=UmeVgtzndfC+stJgNgN0wthoK3jF5pDjAnS5SPxidSZ9UbyaqjtZFPK2OEX8RRp121y6vJ 5f6zLjiHSjetJACA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id C2FA0A3B87; Tue, 12 Apr 2022 09:44:14 +0000 (UTC) Date: Tue, 12 Apr 2022 11:44:14 +0200 Message-ID: From: Takashi Iwai To: Amadeusz =?UTF-8?B?U8WCYXdpxYRza2k=?= Subject: Re: [PATCH v2] ALSA: jack: Access input_dev under mutex In-Reply-To: <20220412091628.3056922-1-amadeuszx.slawinski@linux.intel.com> References: <20220412091628.3056922-1-amadeuszx.slawinski@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Cezary Rojewski , alsa-devel@alsa-project.org, Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 12 Apr 2022 11:16:28 +0200, Amadeusz Sławiński wrote: > > It is possible when using ASoC that input_dev is unregistered while > calling snd_jack_report, which causes NULL pointer dereference. > In order to prevent this serialize access to input_dev using mutex lock. > > Signed-off-by: Amadeusz Sławiński > --- > > Changes: > v2: > - drop mutex in snd_jack_new > - add comment that snd_jack_report() should be called in context where > it can sleep Thanks, applied now. Takashi