From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 829F0C433ED for ; Tue, 18 May 2021 19:32:50 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB751611BF for ; Tue, 18 May 2021 19:32:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB751611BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8BAD516D4; Tue, 18 May 2021 21:31:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8BAD516D4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621366367; bh=bABs/rCtNTS97wgd+HH0dgYeoS9t5yV0LHMmE5vQhQQ=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZKvMkppA9+ocyBwkEwVFCOmieHoa75TO9U8GJroE2ibGhYfD3jKIVCzloUPKufbiy GGH4oLlfrQAhR0wlVq6P9DfB2oU3ov4sNZ4RbO3qX8DtmyEOVA59kB6rgaI/yt/Xb6 AZgEPf237SUJv4hFlKuGQaHP+lkAznUpLXU+JkrE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2B6BBF80217; Tue, 18 May 2021 21:31:57 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 60683F80257; Tue, 18 May 2021 21:31:55 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 23485F801DB for ; Tue, 18 May 2021 21:31:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 23485F801DB X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8486EAF79; Tue, 18 May 2021 19:31:51 +0000 (UTC) Date: Tue, 18 May 2021 21:31:51 +0200 Message-ID: From: Takashi Iwai To: Jaroslav Kysela Subject: Re: [PATCH 2/7] ALSA: control: Add power state check commonly for ioctl handlers In-Reply-To: References: <20210518165201.24376-1-tiwai@suse.de> <20210518165201.24376-3-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Andrey Grodzovsky , ALSA development X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 18 May 2021 20:00:46 +0200, Jaroslav Kysela wrote: > > Dne 18. 05. 21 v 18:51 Takashi Iwai napsal(a): > > The card power state check can be better put in the common ioctl > > handler, as basically we want to prevent ioctls during the power off > > state. Although this situation won't happen normally any longer (*), > > it'll be helpful for catching this for the future implementation like > > the faked suspend that is needed for PCI rescan. > > > > (*) Long long time ago, before the proper PM framework was introduced, > > it was still possible to reach SNDRV_CTL_IOCTL_POWER ioctl during the > > power off state. This ioctl existed as a main control for the suspend > > resume state in the past, but the feature was already dropped along > > with the standard PM framework. > > It seems like a function dup for the 5th patch which tracks in flight the > power state. I think that we should drop this (and reshuffle patches) or > remove this in or after the 5th patch. A good point. With snd_power_ref_and_wait(), we achieve more fine-grained protection, so those checks could be indeed dropped. Will clean up later in the v2 patch. thanks, Takashi