From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCDB0C3A5A4 for ; Fri, 30 Aug 2019 05:39:48 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D980521721 for ; Fri, 30 Aug 2019 05:39:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Y5Vx6ICS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D980521721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C5643829; Fri, 30 Aug 2019 07:38:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C5643829 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1567143585; bh=l1vFu4Vp9cvBsuFhGGV//rirnUetKoOpnbW18fDOPJE=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Y5Vx6ICShJA+IrRJZlA/Fw/dXhxJGyJBhjCXCwDqQRt1BADM3MQjTTMkJapiUufSW e6jI5wb0PsfRCu3r8bsZ9PLeNtF5Vd1NqmGJN0Ssu4/AGO9K0Iwjdsr7SxdZMAq+UT zaDtLfVqH76EmoTMpo64P7CSEIV71Yo3EF3efcsg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 40FB2F800D1; Fri, 30 Aug 2019 07:38:55 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8DAE2F80369; Fri, 30 Aug 2019 07:38:53 +0200 (CEST) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DB2F8F800D1 for ; Fri, 30 Aug 2019 07:38:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DB2F8F800D1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 0655AAE64; Fri, 30 Aug 2019 05:38:50 +0000 (UTC) Date: Fri, 30 Aug 2019 07:38:49 +0200 Message-ID: From: Takashi Iwai To: vani.ganji@intel.com In-Reply-To: <20190830052318.25898-1-vani.ganji@intel.com> References: <20190830052318.25898-1-vani.ganji@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org Subject: Re: [alsa-devel] [PATCH] [PATCH v2] ALSA: hda: Retry codec read on first time failure X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 30 Aug 2019 07:23:18 +0200, vani.ganji@intel.com wrote: > > From: Vani Ganji > > Sometimes HDMI audio fails while fast switching > between HDMI and Speaker due to codec Get Power state verb read failure. > > Verb is codec driver to access codec HW. Since issue scenario involves > fast switching between HDMI and speaker, there might be chance to fail > read from HW and same happened in the error scenario. > > Based on Display/Graphics architect suggestion, added a retry mechanism > for failure on first attempt. > > Changes from v1: > -Corrected missing braces. > > Signed-off-by: Vani Ganji Do you still need this even with the very latest upstream code? As mentioned, the recent change to use the sync-write should reduce such errors. If it's about the SOF/SST, you can try to set the hdac_bus.sync_write flag in the corresponding drivers, too. thanks, Takashi > --- > sound/hda/hdac_device.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/sound/hda/hdac_device.c b/sound/hda/hdac_device.c > index b26cc93e7e10..3874d54aa686 100644 > --- a/sound/hda/hdac_device.c > +++ b/sound/hda/hdac_device.c > @@ -984,10 +984,17 @@ static unsigned int codec_read(struct hdac_device *hdac, hda_nid_t nid, > { > unsigned int cmd = snd_hdac_make_cmd(hdac, nid, verb, parm); > unsigned int res; > - > - if (snd_hdac_exec_verb(hdac, cmd, flags, &res)) > - return -1; > - > + unsigned int count; > + > + /* Retry verb once more if it fails first time */ > + /* recommended to retry since it is HW related */ > + for (count = 0; count <= 1; count++) { > + if (snd_hdac_exec_verb(hdac, cmd, flags, &res)) { > + if (count == 1) > + return -1; > + } else > + break; > + } > return res; > } > > -- > 2.17.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel