From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [alsa-devel] Regression in next with codec unload and      snd_soc_component_get/put
Date: Fri, 09 Aug 2019 09:25:11 +0200
Message-ID: <s5hwofmhkbs.wl-tiwai@suse.de>
References: <20190809070003.GA52127@atomide.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20190809070003.GA52127@atomide.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Tony Lindgren <tony@atomide.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
List-Id: alsa-devel@alsa-project.org

On Fri, 09 Aug 2019 09:00:03 +0200,
Tony Lindgren wrote:
> 
> Hi,
> 
> Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> snd_soc_component_get/put()") causes a regression where trying
> to rmmod a codec driver fails with module is in use error after
> rmmod of snd-soc-audio-graph-card for example.
> 
> Any ideas what goes wrong there?

There is an obvious typo: soc_cleanup_component() should call
snd_soc_component_module_put_when_remove() instead of *_close().

And the module_get_upon_open boolean switch is a bit hard to
understand.  Maybe using enum would be simpler there.

> BTW, looks like the lore.kernel.org link in that commit also is
> unreachable?

It's because alsa-devel ML isn't tracked on lore.kernel.org,
unfortunately.

Jaroslav, I asked this already.  Shall we ask lore to track alsa-devel
ML?
  https://korg.wiki.kernel.org/userdoc/lore


thanks,

Takashi