alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Wandrille RONCE <w@ndrille.fr>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda/realtek: Enable audio jacks of ASUS UX391UA with, ALC294
Date: Tue, 18 Dec 2018 13:43:18 +0100	[thread overview]
Message-ID: <s5hwoo7c8ex.wl-tiwai@suse.de> (raw)
In-Reply-To: <489c2bed-b02b-c957-6c16-1dac5e57007d@ndrille.fr>

On Mon, 17 Dec 2018 22:58:04 +0100,
Wandrille RONCE wrote:
> 
> From c87ce2119f010db78933c424b8ba6738c3056dff Mon Sep 17 00:00:00 2001
> From: Wandrille RONCE <w@ndrille.fr>
> Date: Mon, 17 Dec 2018 19:00:00 +0100
> Subject: [PATCH] ALSA: hda/realtek: Enable audio jacks of ASUS UX391UA with
>  ALC294

The empty log is always bad.  Could you describe what does your patch
do, especially what problem does it fix?

Last but not least, please give your sign-off.  Otherwise we can't
merge the patch.


thanks,

Takashi


> 
> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 15021c839372..90f30e769a42 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6584,6 +6584,7 @@ static const struct snd_pci_quirk
> alc269_fixup_tbl[] = {
>      SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC),
>      SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E",
> ALC269VB_FIXUP_ASUS_ZENBOOK),
>      SND_PCI_QUIRK(0x1043, 0x14a1, "ASUS UX533FD", ALC294_FIXUP_ASUS_SPK),
> +    SND_PCI_QUIRK(0x1043, 0x10a1, "ASUS UX391UA", ALC294_FIXUP_ASUS_SPK),
>      SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A",
> ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
>      SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC),
>      SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),
> -- 
> 2.19.1
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2018-12-18 12:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 21:58 [PATCH] ALSA: hda/realtek: Enable audio jacks of ASUS UX391UA with, ALC294 Wandrille RONCE
2018-12-18 12:43 ` Takashi Iwai [this message]
2018-12-19  2:00   ` Wandrille RONCE
2018-12-19 13:56     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hwoo7c8ex.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=w@ndrille.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).