From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [RFC PATCH 0/7] Fix Intel audio Kconfig issues Date: Tue, 21 Nov 2017 18:10:52 +0100 Message-ID: References: <20171118000202.22302-1-pierre-louis.bossart@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, broonie@kernel.org, torvalds@linux-foundation.org, vinod.koul@intel.com, liam.r.girdwood@linux.intel.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Sat, 18 Nov 2017 10:25:28 +0100, Takashi Iwai wrote: > > On Sat, 18 Nov 2017 01:01:55 +0100, > Pierre-Louis Bossart wrote: > > > > At the risk of being scolded for the third time in two days by > > Linux overlords (no hard feelings), here's an attempt to clean > > things up. > > > > The first patch *should* implement what Linus, Takashi and Mark > > tried to explain by email. There should be no functionality change > > and could be merged if deemed ok. > > > > The rest of the patch series does a more in-depth cleanup and should not > > be merged without more testing (hence the RFC). > > > > The 4th patch is really the most important one, there were nested > > configs which made no sense to me. I don't know the history which led > > to such complicated stuff but simpler is better. > > > > The last 3 patches are just clean-ups of the machine driver configs, > > for some reason there is no consistency in the settings so I tried to > > apply common sense. There might be additional cleanup needed since I > > don't really get why we need references to LPSS or DESIGNWARE for things > > which are not visible to a machine driver, we should only depend on IC2 or > > SPI in my opinion - depending on what the control interface is. > > > > I tried to keep things to a minimum in each patch to make the reviews > > easier, if people want them squashed that's fine by me. > > > > I'll do some more testing on my side but I could use feedback. Thanks! > > FYI, I've put these to a test branch, test/asoc-intel-kconfig, so that > 0day bot can catch issues. Let's see. No news is a good news, it seems that your patchset doesn't break builds, at least. Let's go ahead! Takashi