From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] topology: treat all DAPM controls types
	the same when copying
Date: Fri, 07 Aug 2015 18:07:27 +0200
Message-ID: <s5hwpx7f5fk.wl-tiwai@suse.de>
References: <1438961956-6239-1-git-send-email-liam.r.girdwood@linux.intel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 713E72619FF
 for <alsa-devel@alsa-project.org>; Fri,  7 Aug 2015 18:07:28 +0200 (CEST)
In-Reply-To: <1438961956-6239-1-git-send-email-liam.r.girdwood@linux.intel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Cc: Mengdong Lin <mengdong.lin@intel.com>, alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
List-Id: alsa-devel@alsa-project.org

On Fri, 07 Aug 2015 17:39:15 +0200,
Liam Girdwood wrote:
> 
> From: Mengdong Lin <mengdong.lin@intel.com>
> 
> Copy all DAPM controls types using the same method.
> 
> Signed-off-by: Mengdong Lin <mengdong.lin@intel.com>
> Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>

Applied, thanks.


Takashi

> ---
>  src/topology/dapm.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/src/topology/dapm.c b/src/topology/dapm.c
> index 7e26ea0..a0a8b86 100644
> --- a/src/topology/dapm.c
> +++ b/src/topology/dapm.c
> @@ -107,8 +107,6 @@ static int tplg_parse_dapm_enums(snd_config_t *cfg, struct tplg_elem *elem)
>  static int copy_dapm_control(struct tplg_elem *elem, struct tplg_elem *ref)
>  {
>  	struct snd_soc_tplg_dapm_widget *widget = elem->widget;
> -	struct snd_soc_tplg_mixer_control *mixer_ctrl = ref->mixer_ctrl;
> -	struct snd_soc_tplg_enum_control *enum_ctrl = ref->enum_ctrl;
>  
>  	tplg_dbg("Control '%s' used by '%s'\n", ref->id, elem->id);
>  	tplg_dbg("\tparent size: %d + %d -> %d, priv size -> %d\n",
> @@ -121,13 +119,10 @@ static int copy_dapm_control(struct tplg_elem *elem, struct tplg_elem *ref)
>  
>  	elem->widget = widget;
>  
> -	/* copy new widget at the end */
> -	if (ref->type == OBJECT_TYPE_MIXER)
> -		memcpy((void*)widget + elem->size, mixer_ctrl, ref->size);
> -	else if (ref->type == OBJECT_TYPE_ENUM)
> -		memcpy((void*)widget + elem->size, enum_ctrl, ref->size);
> -
> +	/* append the control to the end of the widget */
> +	memcpy((void*)widget + elem->size, ref->obj, ref->size);
>  	elem->size += ref->size;
> +
>  	widget->num_kcontrols++;
>  	ref->compound_elem = 1;
>  	return 0;
> -- 
> 2.1.4
>