From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v5 2/4] ASoC: Intel - add Skylake HDA audio
	driver
Date: Tue, 16 Jun 2015 17:28:01 +0200
Message-ID: <s5hwpz38ygu.wl-tiwai@suse.de>
References: <1434040438-14535-1-git-send-email-vinod.koul@intel.com>
 <1434040438-14535-3-git-send-email-vinod.koul@intel.com>
 <20150615155632.GU18309@sirena.org.uk>
 <20150616035247.GT28601@localhost>
 <20150616102826.GF18309@sirena.org.uk>
 <20150616152405.GX28601@localhost>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id E9C36265842
 for <alsa-devel@alsa-project.org>; Tue, 16 Jun 2015 17:28:01 +0200 (CEST)
In-Reply-To: <20150616152405.GX28601@localhost>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, patches.audio@intel.com, liam.r.girdwood@linux.intel.com, Mark Brown <broonie@kernel.org>, Jeeja KP <jeeja.kp@intel.com>, "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
List-Id: alsa-devel@alsa-project.org

At Tue, 16 Jun 2015 20:54:05 +0530,
Vinod Koul wrote:
> 
> On Tue, Jun 16, 2015 at 11:28:26AM +0100, Mark Brown wrote:
> > On Tue, Jun 16, 2015 at 09:22:47AM +0530, Vinod Koul wrote:
> > > On Mon, Jun 15, 2015 at 04:56:33PM +0100, Mark Brown wrote:
> > 
> > > > > +static const struct hdac_io_ops skl_io_ops = {
> > > > > +	.reg_writel = skl_pci_writel,
> > > > > +	.reg_readl = skl_pci_readl,
> > > > > +	.reg_writew = skl_pci_writew,
> > > > > +	.reg_readw = skl_pci_readw,
> > > > > +	.reg_writeb = skl_pci_writeb,
> > > > > +	.reg_readb = skl_pci_readb,
> > > > > +	.dma_alloc_pages = skl_dma_alloc_pages,
> > > > > +	.dma_free_pages = skl_dma_free_pages,
> > > > > +};
> > 
> > > > Still not thrilled at open coding these wrappers.
> > 
> > > If we have this is core, I will remove the part :)
> > 
> > You could always send changes to add default ops to the core!
> Takashi, you okay with that approach?

Yes.


Takashi