From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org, broonie@kernel.org,
Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [PATCH v9 2/3] ALSA: hdac_ext: add hdac extended controller
Date: Thu, 11 Jun 2015 11:10:24 +0200 [thread overview]
Message-ID: <s5hwpza7gqn.wl-tiwai@suse.de> (raw)
In-Reply-To: <1434012109-20164-3-git-send-email-vinod.koul@intel.com>
At Thu, 11 Jun 2015 14:11:48 +0530,
Vinod Koul wrote:
>
> +struct hdac_ext_link *snd_hdac_ext_bus_get_link(struct hdac_ext_bus *ebus,
> + const char *codec_name)
> +{
> + int i;
> + struct hdac_ext_link *hlink = NULL;
> + int bus_idx, addr;
> +
> + if (sscanf(codec_name, "ehdaudio%dD%d", &bus_idx, &addr) != 2)
> + return NULL;
> + if (ebus->idx != bus_idx)
> + return NULL;
> +
> + list_for_each_entry(hlink, &ebus->hlink_list, list) {
> + for (i = 0; i < HDA_MAX_CODECS; i++) {
> + if (hlink->lsdiid && (0x1 << addr))
This should be single '&'.
But I can correct it by myself at applying, so no need for resend if
no other problem is seen.
Takashi
next prev parent reply other threads:[~2015-06-11 9:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 8:41 [PATCH v9 0/3] HDA: add extended HDA Vinod Koul
2015-06-11 8:41 ` [PATCH v9 1/3] ALSA: hdac_ext: add extended HDA bus Vinod Koul
2015-06-11 8:41 ` [PATCH v9 2/3] ALSA: hdac_ext: add hdac extended controller Vinod Koul
2015-06-11 9:10 ` Takashi Iwai [this message]
2015-06-11 8:41 ` [PATCH v9 3/3] ALSA: hdac_ext: add extended stream capabilities Vinod Koul
2015-06-11 13:19 ` [PATCH v9 0/3] HDA: add extended HDA Takashi Iwai
2015-06-11 16:45 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwpza7gqn.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox