From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v3 4/7] ASoC: intel - add Skylake HDA
	platform driver
Date: Thu, 30 Apr 2015 11:52:47 +0200
Message-ID: <s5hwq0udjtc.wl-tiwai@suse.de>
References: <1430250870-3169-1-git-send-email-vinod.koul@intel.com>
 <1430250870-3169-5-git-send-email-vinod.koul@intel.com>
 <s5hy4lbf75l.wl-tiwai@suse.de> <20150430094221.GM3521@localhost>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 215602651C0
 for <alsa-devel@alsa-project.org>; Thu, 30 Apr 2015 11:52:48 +0200 (CEST)
In-Reply-To: <20150430094221.GM3521@localhost>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, patches.audio@intel.com, liam.r.girdwood@linux.intel.com, broonie@kernel.org, Jeeja KP <jeeja.kp@intel.com>, "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
List-Id: alsa-devel@alsa-project.org

At Thu, 30 Apr 2015 15:12:21 +0530,
Vinod Koul wrote:
> 
> On Wed, Apr 29, 2015 at 02:31:02PM +0200, Takashi Iwai wrote:
> > At Wed, 29 Apr 2015 01:24:27 +0530,
> > Vinod Koul wrote:
> > > 
> > > +static struct snd_soc_dai_driver soc_hda_platform_dai[] = {
> > > +{
> > > +	.name = "System Pin",
> > > +	.ops = &hda_pcm_dai_ops,
> > > +	.playback = {
> > > +		.stream_name = "System Playback",
> > > +		.channels_min = HDA_MONO,
> > > +		.channels_max = HDA_STEREO,
> > > +		.rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_8000,
> > > +		.formats = SNDRV_PCM_FMTBIT_S16_LE,
> > > +	},
> > > +	.capture = {
> > > +		.stream_name = "System Capture",
> > > +		.channels_min = HDA_MONO,
> > > +		.channels_max = HDA_STEREO,
> > > +		.rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_16000,
> > > +		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE,
> > 
> > Is it really S24_LE?  It's packed in lower 3 bytes of 4 bytes format.
> Yup, we do use S24_LE, thats very common on our DSP based systems

OK.

> > > +	},
> > > +},
> > > +{
> > > +	.name = "Deepbuffer Pin",
> > > +	.ops = &hda_pcm_dai_ops,
> > > +	.playback = {
> > > +		.stream_name = "Deepbuffer Playback",
> > > +		.channels_min = HDA_STEREO,
> > > +		.channels_max = HDA_STEREO,
> > > +		.rates = SNDRV_PCM_RATE_48000,
> > > +		.formats = SNDRV_PCM_FMTBIT_S16_LE,
> > > +	},
> > > +},
> > > +{
> > > +	.name = "LowLatency Pin",
> > > +	.ops = &hda_pcm_dai_ops,
> > > +	.playback = {
> > > +		.stream_name = "Low Latency Playback",
> > > +		.channels_min = HDA_STEREO,
> > > +		.channels_max = HDA_STEREO,
> > > +		.rates = SNDRV_PCM_RATE_48000,
> > > +		.formats = SNDRV_PCM_FMTBIT_S16_LE,
> > > +	},
> > 
> > Are there no S32_LE support at all for all dais?
> No, just 16 and 24 bits :)

Hm, so this restriction remains also for decoupled from DSP?

All HDA codecs supports 24bit formats (in S32_LE form), but in your
patch, 24bit format is supported only for System Capture.


Takashi