From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 1/1] driver/snd: es18xx driver should use udelay error Date: Mon, 14 Apr 2014 14:30:17 +0200 Message-ID: References: <1397468588-18559-1-git-send-email-zhen-hual@hp.com> <534BCDE8.1090202@ladisch.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <534BCDE8.1090202@ladisch.de> Sender: linux-kernel-owner@vger.kernel.org To: Clemens Ladisch Cc: "Li, Zhen-Hua" , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org At Mon, 14 Apr 2014 14:00:40 +0200, Clemens Ladisch wrote: > > Li, Zhen-Hua wrote: > > udelay with more than 20000 may cause __bad_udelay. > > Use mdelay for instead. > > > > #ifdef AVOID_POPS > > /* Avoid pops */ > > - udelay(100000); > > + mudelay(100); > > This will not compile. Please test with AVOID_POPS enabled. Oops, thanks for spotting. I fixed it now. Takashi