From: Takashi Iwai <tiwai@suse.de>
To: Matthias Larisch <mail@matthias-larisch.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] src/pcm/pcm_ladspa.c: Delay LADSPA plugin activate call
Date: Thu, 03 Apr 2014 12:02:32 +0200 [thread overview]
Message-ID: <s5hwqf6rarr.wl%tiwai@suse.de> (raw)
In-Reply-To: <20140327190510.5cf481d0@purefruit>
At Thu, 27 Mar 2014 19:05:10 +0100,
Matthias Larisch wrote:
>
> Some LADSPA Plugins rely on connected control ports on activate call.
> While this is not okay by spec, the spec also encourages the activate
> call happening as late as possible.
>
> Signed-off-by: Matthias Larisch <mail@matthias-larisch.de>
Thanks, applied.
Takashi
> ---
> src/pcm/pcm_ladspa.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/pcm/pcm_ladspa.c b/src/pcm/pcm_ladspa.c
> index 9ce5242..7d1e3df 100644
> --- a/src/pcm/pcm_ladspa.c
> +++ b/src/pcm/pcm_ladspa.c
> @@ -645,8 +645,6 @@ static int snd_pcm_ladspa_allocate_instances(snd_pcm_t
> *pcm, snd_pcm_ladspa_t *l return -EINVAL;
> }
> list_add_tail(&instance->list, &plugin->instances);
> - if (plugin->desc->activate)
> - plugin->desc->activate(instance->handle);
> if (plugin->policy == SND_PCM_LADSPA_POLICY_DUPLICATE)
> { err = snd_pcm_ladspa_connect_plugin_duplicate(plugin, &plugin->input,
> &plugin->output, instance, idx); if (err < 0) {
> @@ -664,6 +662,8 @@ static int snd_pcm_ladspa_allocate_instances(snd_pcm_t
> *pcm, snd_pcm_ladspa_t *l assert(err >= 0);
> err = snd_pcm_ladspa_connect_controls(plugin,
> &plugin->output, instance); assert(err >= 0);
> + if (plugin->desc->activate)
> + plugin->desc->activate(instance->handle);
> }
> err = snd_pcm_ladspa_check_connect(plugin, &plugin->input,
> &instance->input, depth); if (err < 0)
> --
> 1.9.1
> [1.2 signature.asc <application/pgp-signature (7bit)>]
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2014-04-03 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 18:05 [PATCH] src/pcm/pcm_ladspa.c: Delay LADSPA plugin activate call Matthias Larisch
2014-04-03 10:02 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwqf6rarr.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=mail@matthias-larisch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox