alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mihail Zenkov <mihail.zenkov@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] Fix regression in emu1010 firmware loading
Date: Fri, 22 Feb 2013 16:42:21 +0100	[thread overview]
Message-ID: <s5hwqu04aoy.wl%tiwai@suse.de> (raw)
In-Reply-To: <CAD-m0i_1Tkra9qht3h_Bos=TgiYJ0u4bGnKuQ9gL4s4aWm9fig@mail.gmail.com>

At Fri, 22 Feb 2013 11:25:27 +0000,
Mihail Zenkov wrote:
> 
> This patch fix regression in emu1010 firmware loading after
> http://git.alsa-project.org/?p=alsa-kprivate.git;a=commitdiff;h=b209c4dfcd960ab176d4746ab7dc442a3edb4575
> 
> I just revert small part of this commit. Tested on emu1212m pci.
> 
> Signed-off-by: Mihail Zenkov <mihail.zenkov@gmail.com>

Thanks, applied.


Takashi

> --- linux-3.8/sound/pci/emu10k1/emu10k1_main.c
> +++ linux-3.8-1/sound/pci/emu10k1/emu10k1_main.c
> @@ -860,6 +860,11 @@
>  		}
>  		snd_printk(KERN_INFO "emu1010: firmware file = %s, size = 0x%zx\n",
>  			   filename, emu->firmware->size);
> +		err = snd_emu1010_load_firmware(emu);
> +		if (err != 0) {
> +			snd_printk(KERN_INFO "emu1010: Loading Firmware file %s failed\n",
> filename);
> +			return err;
> +		}
>  	}
> 
>  	/* ID, should read & 0x7f = 0x55 when FPGA programmed. */
> 

      reply	other threads:[~2013-02-22 15:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-21 21:06 [PATCH] Fix regression in emu1010 firmware loading Mihail Zenkov
2013-02-22  6:19 ` Takashi Iwai
2013-02-22 11:25   ` Mihail Zenkov
2013-02-22 15:42     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hwqu04aoy.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=mihail.zenkov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).