From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] hda-codec - Fix definition of AC_KNBCAP_DELTA to match spec Date: Mon, 17 Dec 2007 10:24:00 +0100 Message-ID: References: <3681a8bf780ea1be9bf6.1197654480@firewall.26broadway.net> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id CE4DA1038CC for ; Mon, 17 Dec 2007 12:00:07 +0100 (CET) In-Reply-To: <3681a8bf780ea1be9bf6.1197654480@firewall.26broadway.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Andrew Paprocki Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Fri, 14 Dec 2007 12:48:00 -0400, Andrew Paprocki wrote: > > AC_KNBCAP_DELTA is incorrectly defined as (1<<8). According to the Intel > HDA spec, this is bit 7 after AC_KNBCAP_NUM_STEPS which is a 0x7f mask. > > Signed-off-by: Andrew Paprocki Applied to HG tree now. Thanks. Takashi > > diff -r 4a204306b295 -r 3681a8bf780e pci/hda/hda_codec.h > --- a/pci/hda/hda_codec.h Fri Dec 14 14:42:41 2007 +0100 > +++ b/pci/hda/hda_codec.h Fri Dec 14 12:27:35 2007 -0500 > @@ -234,7 +234,7 @@ enum { > > /* Volume knobs capabilities */ > #define AC_KNBCAP_NUM_STEPS (0x7f<<0) > -#define AC_KNBCAP_DELTA (1<<8) > +#define AC_KNBCAP_DELTA (1<<7) > > /* > * Control Parameters > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >