From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] Add framework for better audigy sound card capabilities selection. Date: Tue, 22 Mar 2005 10:56:04 +0100 Message-ID: References: <423B345F.3000901@hotmail.com> <423F3B2E.4020400@superbug.co.uk> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Received: from mail.suse.de (cantor.suse.de [195.135.220.2]) by alsa.alsa-project.org (ALSA's E-mail Delivery System) with ESMTP id 3A331259 for ; Tue, 22 Mar 2005 10:56:19 +0100 (MET) In-Reply-To: <423F3B2E.4020400@superbug.co.uk> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: James Courtier-Dutton Cc: ALSA development List-Id: alsa-devel@alsa-project.org At Mon, 21 Mar 2005 21:22:54 +0000, James Courtier-Dutton wrote: > > [1 ] > Takashi Iwai wrote: > > Hi, > > > > the idea looks nice, but... > > > > Is this better? Thanks! One more correction below: > --- alsa-driver/alsa-kernel/pci/emu10k1/emu10k1_main.c 17 Mar 2005 15:55:16 -0000 1.45 > +++ alsa-driver/alsa-kernel/pci/emu10k1/emu10k1_main.c 21 Mar 2005 21:18:50 -0000 > @@ -612,6 +612,144 @@ > return snd_emu10k1_free(emu); > } > > +/* vendor, device, subsystem, emu10k1_chip, emu10k2_chip, ca0102_chip, ca0108_chip, ca0151_chip, spk71, spdif_bug, ac97_chip, ecard, driver, name */ > + > +static emu_chip_details_t emu_chip_details[] = { > + /* Audigy 2 Value AC3 out does not work yet. Need to find out how to turn off interpolators.*/ > + {.vendor = 0x1102, .device = 0x0008, .subsystem = 0x10011102, > + .emu10k1_chip = 0, You don't need to initialize fields with zero. That's another advantage of this initialization style. Takashi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click