Re: [2.6 patch] ALSA core: misc cleanups

[Takashi Iwai <tiwai@suse.de>]

At Fri, 26 Nov 2004 01:24:48 +0100,
Adrian Bunk wrote:
> 
> The patch below does the following cleanups under sound/core/ :
> - make needlessly global code static
> - remove the following stale prototypes from pcm.h
>   (the functions are not or no longer present):
>   - snd_pcm_capture_ready_jiffies
>   - snd_pcm_playback_ready_jiffies
> - remove the following unused global funxtions:
>   - oss/pcm_plugin.c: snd_pcm_plug_capture_channels_mask
>   - pcm_lib.c: snd_pcm_playback_ready
>   - pcm_lib.c: snd_pcm_capture_ready
>   - pcm_lib.c: snd_pcm_capture_empty
>   - pcm_misc.c: snd_pcm_format_cpu_endian
>   - pcm_misc.c: snd_pcm_format_size
>   - seq/seq_instr.c: snd_seq_cluster_new
>   - seq/seq_instr.c: snd_seq_cluster_free
>   - seq/seq_midi_event.c: snd_midi_event_init
>   - seq/seq_midi_event.c: snd_midi_event_resize_buffer
>   - seq/seq_virmidi.c: snd_virmidi_receive
> - remove the following unused EXPORT_SYMBOL's:
>   - snd_create_proc_entry
>   - snd_interval_ratden
>   - snd_midi_channel_init
>   - snd_midi_channel_init_set
>   - snd_midi_event_init
>   - snd_midi_event_resize_buffer
>   - snd_pcm_capture_empty
>   - snd_pcm_capture_poll
>   - snd_pcm_capture_ready
>   - snd_pcm_format_size
>   - snd_pcm_lib_preallocate_free
>   - snd_pcm_open
>   - snd_pcm_playback_poll
>   - snd_pcm_playback_ready
>   - snd_pcm_release
>   - snd_pcm_subformat_name
>   - snd_pcm_suspend
>   - snd_rawmidi_drain_input
>   - snd_rawmidi_drop_output
>   - snd_rawmidi_info
>   - snd_remove_proc_entry
>   - snd_timer_continue
>   - snd_timer_system_resolution
>   - snd_virmidi_receive

I disagree to remove all of these functions from the middle layer.
Some of them could be reduced, but others were once used, and might be
used in future, too.


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/