From: Takashi Iwai <tiwai@suse.de>
To: Stephen Warren <SWarren@nvidia.com>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: Bug in acore/memalloc.patch in alsa-driver-1.0.7?
Date: Fri, 19 Nov 2004 18:50:44 +0100 [thread overview]
Message-ID: <s5hwtwhaft7.wl@alsa2.suse.de> (raw)
In-Reply-To: <DBFABB80F7FD3143A911F9E6CFD477B002A7F816@hqemmail02.nvidia.com>
At Fri, 19 Nov 2004 09:05:43 -0800,
Stephen Warren wrote:
>
> This changes the code from
>
> - if (dev == NULL || !dev->dma_mask)
>
> to:
>
> - if (dev == NULL || (dev)->dma_mask)
>
> Once the macro is expanded for kernels 2.6.0 or later.
>
> This seems to be a bug, since the test is inverted.
Yep, you're ring. Now fixed on cvs.
Thanks.
Takashi
-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
prev parent reply other threads:[~2004-11-19 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-19 17:05 Bug in acore/memalloc.patch in alsa-driver-1.0.7? Stephen Warren
2004-11-19 17:50 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwtwhaft7.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=SWarren@nvidia.com \
--cc=alsa-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox