Re: RME HDSP9652

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

At 28 Nov 2002 14:39:41 +0000,
Justin Cormack wrote:
> 
> On Thu, 2002-11-28 at 13:42, Paul Davis wrote:
> > >I have just got a couple of the new RME Hammerfall HDSP9652 cards, and
> > >find that they are not supported by the snd-hdsp driver yet. The card is
> > >basically the same hardware as the other hdsp cards but with the io
> > >integrated on the card.
> > >
> > >I would guess that it will need a different firmware and another type in
> > >HDSP_Type, plus the channel info.  Does anyone know how to get the
> > >formware from RME (who to contact)?
> > 
> > all i need is the PCI ID from you. i've already spoken to RME about
> > the card, and the claim is that it will with the existing h-dsp
> > driver. the only thing that won't work are the RMS meters. the
> > existing driver, however, doesn't recognize the PCI ID and so it
> > doesn't work.
> > 
> 
> Its the same PCI ID, but insmod segfaults...

does the attched patch cure the segfault?
but it doesn't mean that your card will be supported by it :)


Takashi

[-- Attachment #2: hdsp-fix.dif --]
[-- Type: application/octet-stream, Size: 983 bytes --]

Index: alsa-kernel/pci/rme9652/hdsp.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/rme9652/hdsp.c,v
retrieving revision 1.11
diff -u -r1.11 hdsp.c
--- alsa-kernel/pci/rme9652/hdsp.c	25 Nov 2002 10:13:58 -0000	1.11
+++ alsa-kernel/pci/rme9652/hdsp.c	28 Nov 2002 15:38:07 -0000
@@ -3045,9 +3045,11 @@
 
 static int snd_hdsp_free(hdsp_t *hdsp)
 {
-	/* stop the audio, and cancel all interrupts */
-	hdsp->control_register &= ~(HDSP_Start|HDSP_AudioInterruptEnable|HDSP_Midi0InterruptEnable|HDSP_Midi1InterruptEnable);
-	hdsp_write (hdsp, HDSP_controlRegister, hdsp->control_register);
+	if (hdsp->res_port) {
+		/* stop the audio, and cancel all interrupts */
+		hdsp->control_register &= ~(HDSP_Start|HDSP_AudioInterruptEnable|HDSP_Midi0InterruptEnable|HDSP_Midi1InterruptEnable);
+		hdsp_write (hdsp, HDSP_controlRegister, hdsp->control_register);
+	}
 
 	if (hdsp->irq >= 0)
 		free_irq(hdsp->irq, (void *)hdsp);