From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [ALSA patch] [PATCH 1/2] alsa: pcm: add
	unsupported OPS
Date: Tue, 09 Jul 2019 14:25:00 +0200
Message-ID: <s5hy317tmxv.wl-tiwai@suse.de>
References: <1562583889-2109-1-git-send-email-amiartus@de.adit-jv.com>
 <1562583889-2109-2-git-send-email-amiartus@de.adit-jv.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (mx2.suse.de [195.135.220.15])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by alsa1.perex.cz (Postfix) with ESMTPS id 9A2D9F800E0
 for <alsa-devel@alsa-project.org>; Tue,  9 Jul 2019 14:25:01 +0200 (CEST)
In-Reply-To: <1562583889-2109-2-git-send-email-amiartus@de.adit-jv.com>
List-Unsubscribe: <https://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <https://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: "Alsa-devel" <alsa-devel-bounces@alsa-project.org>
To: Adam Miartus <amiartus@de.adit-jv.com>
Cc: alsa-devel@alsa-project.org, Andreas Pape <apape@de.adit-jv.com>
List-Id: alsa-devel@alsa-project.org

On Mon, 08 Jul 2019 13:04:48 +0200,
Adam Miartus wrote:
> 
> From: Andreas Pape <apape@de.adit-jv.com>
> 
> Signed-off-by: Andreas Pape <apape@de.adit-jv.com>
> Signed-off-by: Adam Miartus <amiartus@de.adit-jv.com>

No description isn't good at all.  There must be something you can
explain in details here.

About the changes:

> +#define PCM_UNSUPPORTED_ERR (-ENOSYS)
> +void snd_pcm_unsupported_dump(snd_pcm_t *pcm, snd_output_t *out)
> +{
> +	snd_output_printf(out, "unsupported\n");
> +}

IMO, we don't need to show anything if it's dummy.
And, maybe it's more straightforward to let the PCM core allow NULL
ops?


thanks,

Takashi