From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v5 2/4] ASoC: Intel - add Skylake HDA audio
	driver
Date: Tue, 16 Jun 2015 17:27:40 +0200
Message-ID: <s5hy4jj8yhf.wl-tiwai@suse.de>
References: <1434040438-14535-1-git-send-email-vinod.koul@intel.com>
 <1434040438-14535-3-git-send-email-vinod.koul@intel.com>
 <20150615155632.GU18309@sirena.org.uk>
 <s5hoakhexq3.wl-tiwai@suse.de>
 <20150615164202.GW18309@sirena.org.uk>
 <s5hk2v4gbrq.wl-tiwai@suse.de> <20150616152527.GY28601@localhost>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 876082657FE
 for <alsa-devel@alsa-project.org>; Tue, 16 Jun 2015 17:27:41 +0200 (CEST)
In-Reply-To: <20150616152527.GY28601@localhost>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, patches.audio@intel.com, liam.r.girdwood@linux.intel.com, Mark Brown <broonie@kernel.org>, Jeeja KP <jeeja.kp@intel.com>, "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
List-Id: alsa-devel@alsa-project.org

At Tue, 16 Jun 2015 20:55:27 +0530,
Vinod Koul wrote:
> 
> On Mon, Jun 15, 2015 at 06:46:33PM +0200, Takashi Iwai wrote:
> > At Mon, 15 Jun 2015 17:42:02 +0100,
> > Mark Brown wrote:
> > > 
> > > On Mon, Jun 15, 2015 at 06:35:16PM +0200, Takashi Iwai wrote:
> > > > Mark Brown wrote:
> > > > > On Thu, Jun 11, 2015 at 10:03:56PM +0530, Vinod Koul wrote:
> > > 
> > > > > > +	for (i = 0; i < num_stream; i++) {
> > > > > > +		struct hdac_ext_stream *stream =
> > > > > > +				kzalloc(sizeof(*stream), GFP_KERNEL);
> > > 
> > > > > Still not sure why these are Sky Lake specific?
> > > 
> > > > Currently the allocation and the free of each HDA(-ext) stream are
> > > > left to each controller driver.  (See the stream object is embedded.)
> > > 
> > > It looks awfully like it's dynamically allocated here...
> > > 
> > > > And, yes, the allocation (especially the assignment of the stream tag)
> > > > *is* SKL specific.  SKL has some twists in the interpretation of
> > > > HD-audio spec.
> > > 
> > > I can see the thing calling these functions being driver specific but as
> > > far as I can see all these are doing is allocating structs, initialising
> > > them with passed in parameters, putting them on a list and calling a
> > > core function on them.  It's not the bit taking the decisions, it's just
> > > doing mechanical things.
> > 
> > Actually, this can be done a bit more cleanly -- if there will be no
> > more additions to the stream object.  It wasn't clear, so the
> > allocation and free are left to the driver, so far.
> Stream object shouldnt be modfied, so in that case should I move this to
> core and ext/ ?

If there won't be any changes in your side, it's fine to merge into
hda/ext.


Takashi