From: Takashi Iwai <tiwai@suse.de>
To: "Johan Rastén" <johan@oljud.se>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/1] usb-audio: Set correct type for some UAC2 mixer controls.
Date: Thu, 11 Jun 2015 11:08:18 +0200 [thread overview]
Message-ID: <s5hy4jq7gu5.wl-tiwai@suse.de> (raw)
In-Reply-To: <1434009891-16276-1-git-send-email-johan@oljud.se>
At Thu, 11 Jun 2015 10:04:51 +0200,
Johan Rastén wrote:
>
> Changed ctl type for Input Gain Control and Input Gain Pad Control to
> USB_MIXER_S16 as per section 5.2.5.7.11-12 in the USB Audio Class 2.0
> definition.
>
> Signed-off-by: Johan Rastén <johan@oljud.se>
Do you have a device that actually uses these stuff?
I'm asking whether this fix any real device, or just hypothetical.
In the former case, it should go to 4.1. For the latter, we can
postpone to 4.2.
thanks,
Takashi
> diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
> index 8b7e391..6b3acba 100644
> --- a/sound/usb/mixer.c
> +++ b/sound/usb/mixer.c
> @@ -809,12 +809,12 @@ static struct usb_feature_control_info audio_feature_info[] = {
> { "Tone Control - Treble", USB_MIXER_S8 },
> { "Graphic Equalizer", USB_MIXER_S8 }, /* FIXME: not implemeted yet */
> { "Auto Gain Control", USB_MIXER_BOOLEAN },
> - { "Delay Control", USB_MIXER_U16 },
> + { "Delay Control", USB_MIXER_U16 }, /* FIXME: U32 in UAC2 */
> { "Bass Boost", USB_MIXER_BOOLEAN },
> { "Loudness", USB_MIXER_BOOLEAN },
> /* UAC2 specific */
> - { "Input Gain Control", USB_MIXER_U16 },
> - { "Input Gain Pad Control", USB_MIXER_BOOLEAN },
> + { "Input Gain Control", USB_MIXER_S16 },
> + { "Input Gain Pad Control", USB_MIXER_S16 },
> { "Phase Inverter Control", USB_MIXER_BOOLEAN },
> };
>
> --
> 2.1.4
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2015-06-11 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 8:04 [PATCH 1/1] usb-audio: Set correct type for some UAC2 mixer controls Johan Rastén
2015-06-11 9:08 ` Takashi Iwai [this message]
2015-06-11 9:26 ` Johan Aires Rastén
2015-06-11 9:57 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy4jq7gu5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=johan@oljud.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox