From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v3 3/7] ASoC: hda - adds SoC controller and
	stream operations
Date: Thu, 30 Apr 2015 11:49:34 +0200
Message-ID: <s5hy4ladjyp.wl-tiwai@suse.de>
References: <1430250870-3169-1-git-send-email-vinod.koul@intel.com>
 <1430250870-3169-4-git-send-email-vinod.koul@intel.com>
 <s5hzj5rf7cv.wl-tiwai@suse.de> <20150430093504.GL3521@localhost>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 8737826168C
 for <alsa-devel@alsa-project.org>; Thu, 30 Apr 2015 11:49:37 +0200 (CEST)
In-Reply-To: <20150430093504.GL3521@localhost>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com, alsa-devel@alsa-project.org, broonie@kernel.org, Jeeja KP <jeeja.kp@intel.com>
List-Id: alsa-devel@alsa-project.org

At Thu, 30 Apr 2015 15:05:04 +0530,
Vinod Koul wrote:
> 
> On Wed, Apr 29, 2015 at 02:26:40PM +0200, Takashi Iwai wrote:
> > At Wed, 29 Apr 2015 01:24:26 +0530,
> > Vinod Koul wrote:
> > > 
> > > +struct soc_hdac_stream {
> > > +	struct hdac_stream hstream;
> > > +	unsigned int decoupled:1;
> > > +	void __iomem *pphc_addr; /* processing pipe host stream reg pointer */
> > > +	void __iomem *pplc_addr; /* processing pipe link stream reg pointer */
> > > +	bool link_locked:1;
> > > +	struct snd_pcm_substream *link_substream;
> > > +	bool link_prepared;
> > 
> > The bit fields should be gathered into the same place so that the
> > struct can be packed better.  Also, use bool consistently for bit
> > fields, too.
> Sure, btw should we use bitfields or bool alone. I dont see much reason to
> use bitfields here?

You can use a bit field for boolean instead of unsigned int, e.g.
	bool foo:1;

> > > +			continue;
> > > +
> > > +		if (hlink->lsdiid && (0x1 << addr)) {
> > > +			snprintf(hlink->codec[addr],
> > > +					sizeof(hlink->codec[addr]),
> > > +					"codec#%03x.%d", addr, addr);
> > 
> > Does repeating the address twice make sense?
> It doesnt :)

Looking at the codec side, it might be that the ASoC core appends the
dot automatically?  If so, we may accept it, of course.


Takashi