From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v3 0/2] ALSA: jack: Refactoring for jack kctls Date: Mon, 23 Mar 2015 17:38:22 +0100 Message-ID: References: <1426865953-1606-1-git-send-email-yang.jie@intel.com> <550FDA5B.8020604@canonical.com> <20150323150031.GB14954@sirena.org.uk> <20150323163543.GD14954@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 145F026044D for ; Mon, 23 Mar 2015 17:38:23 +0100 (CET) In-Reply-To: <20150323163543.GD14954@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: liam.r.girdwood@intel.com, alsa-devel@alsa-project.org, David Henningsson List-Id: alsa-devel@alsa-project.org At Mon, 23 Mar 2015 09:35:43 -0700, Mark Brown wrote: > > > Now the question is whether we need representing the same item for > > input jack, even though it's nothing but a place holder. If we want > > to have consistency between input and kctl jack items, then yes. > > OTOH, we might want to drop buttons from kctls in anyway, so such a > > consistency has no importance. Then we may just ignore phantom jacks > > for input jacks but create only phatom jack kctls, too, either by > > adding a new flag to indicate that, or let type=0 behaving like that. > > I'm not sure I see the relevancy of buttons here? Well, you pointed that buttons are needed only for input devices, that implicitly means that we don't need to create kctls for buttons. That is, it's not guaranteed that all jack items have to be present in as both input and kctl. Following this logic, we may make phantom jacks only appearing in kctls but not in input. Takashi