From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] pcm: add new 32-bit DSD sample format
Date: Thu, 20 Nov 2014 10:58:29 +0100
Message-ID: <s5hy4r6xkfu.wl-tiwai@suse.de>
References: <1410332428-16571-1-git-send-email-gtmkramer@xs4all.nl>
 <546CF486.7010009@sonarnerd.net>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 3C77426598C
 for <alsa-devel@alsa-project.org>; Thu, 20 Nov 2014 10:58:32 +0100 (CET)
In-Reply-To: <546CF486.7010009@sonarnerd.net>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Jussi Laako <jussi@sonarnerd.net>
Cc: alsa-devel@alsa-project.org, Jurgen Kramer <gtmkramer@xs4all.nl>
List-Id: alsa-devel@alsa-project.org

At Wed, 19 Nov 2014 21:50:30 +0200,
Jussi Laako wrote:
> 
> Hi,
> 
> Sorry for catching up late on this patch...
> 
> On 10.09.2014 10:00, Jurgen Kramer wrote:
> > +	FORMATD(DSD_U32_LE, "Direct Stream Digital, 4-byte (x32), little endian, oldest bits in MSB"),
> 
> There is bug in this patch. The spec for these formats is, as above says 
> "little endian, oldest bits in MSB", however with the iFi iDSD Nano this 
> doesn't seem to be the case. Oldest bits are in MSB of the byte, but 
> byte order is big endian.

Is it a bug of spec, or a bug of device?
In the latter case, we'd need to introduce DSD_U32_BE format and apply
a quirk, for example.


Takashi

> IOW, following alone will produce incorrect 
> output:
> 
> size_t N = 32;
> uint32_t x = 0;
> while (N--)
> {
> 	x <<= 1;
> 	x |= nextbit;
> }
> 
> But if you add __builtin_byteswap32(x) then the output is correct.
> 
> I guess this has not been caught because of just memcpy()'ing the 
> oldest-bit-in-MSB byte stream to the sample buffer instead of 
> constructing the words...
> 
> 
> Best regards,
> 
> 	- Jussi
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>