From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ASoC: Intel: Make sure we only build SST drivers on X86 Date: Wed, 19 Feb 2014 17:15:44 +0100 Message-ID: References: <1392818784-6248-1-git-send-email-liam.r.girdwood@linux.intel.com> <1392818784-6248-2-git-send-email-liam.r.girdwood@linux.intel.com> <20140219150040.GD2669@sirena.org.uk> <20140219155758.GK2669@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 7A52B265A44 for ; Wed, 19 Feb 2014 17:15:45 +0100 (CET) In-Reply-To: <20140219155758.GK2669@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Liam Girdwood , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Thu, 20 Feb 2014 00:57:58 +0900, Mark Brown wrote: > > On Wed, Feb 19, 2014 at 04:21:05PM +0100, Takashi Iwai wrote: > > Mark Brown wrote: > > > > But lots of architectures do actually have these operations, I suspect > > > looking at some of the existing users depending on PCI is enough if > > > excessively strict (this will improve build coverage which tends to be > > > useful even if the driver can't be run). > > > Yes. I guess including linux/io.h should fix the build issue. > > It should for PowerPC (and ought to be done anyway since an implicit > include is going to break eventually on x86 too) but it won't for > architectures that don't have the function at all. memcpy_toio() is supposed to be defined in all architecture. If the arch doesn't support it properly, it still should take from asm-generic/io.h. So, it's a good test coverage for such archs ;) Takashi