Re: 2.6.29 regression: left audio channel broken after resume from suspend with Intel HDA

[Takashi Iwai <tiwai@suse.de>]

At Thu, 7 May 2009 09:23:53 +0200,
Tino Keitel wrote:
> 
> On Thu, May 07, 2009 at 00:27:53 +0200, Tino Keitel wrote:
> > On Tue, Apr 28, 2009 at 02:23:09 +0200, Tino Keitel wrote:
> > 
> > [...]
> > 
> > > I just saw another, major problem: line in doesn't work anymore with
> > > 2.6.29 and also 2.6.30-rc3 (no usable input level). It works with
> > > 2.6.27.20.
> > 
> > FYI: I just tried 2.6.28 and line-in was still broken. So the last
> > working kernel is 2.6.27.
> 
> I tried this:
> 
> git bisect start v2.6.28 v2.6.27 sound/pci/hda/patch_sigmatel.c
> 
> The result is commit 4f1e6bc3646ab50b8181555ab7e6eeab68b8632a.

Could you try the patch below instead?

The problem is that BIOS on your machine sets this pin both for
input and output.  Since it's set as input, the driver respects
the BIOS setup and skips to override.

So, it's a BIOS problem, as usual :)


thanks,

Takashi

---
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index 76487de..e58e008 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -4084,7 +4084,9 @@ static int stac92xx_init(struct hda_codec *codec)
 				pinctl = snd_hda_codec_read(codec, nid, 0,
 					AC_VERB_GET_PIN_WIDGET_CONTROL, 0);
 				/* if PINCTL already set then skip */
-				if (!(pinctl & AC_PINCTL_IN_EN)) {
+				if (!(pinctl & AC_PINCTL_IN_EN) ||
+				    (pinctl & AC_PINCTL_OUT_EN)) {
+					pinctl &= ~AC_PINCTL_OUT_EN;
 					pinctl |= AC_PINCTL_IN_EN;
 					stac92xx_auto_set_pinctl(codec, nid,
 								 pinctl);