Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Alsa-devel <alsa-devel@alsa-project.org>,
	Rene Herman <rene.herman@keyaccess.nl>
Subject: Re: [PATCH 2/2] ad1848: replace duplicated constants in	cs4231
Date: Thu, 19 Jun 2008 11:10:00 +0200	[thread overview]
Message-ID: <s5hy75194ev.wl%tiwai@suse.de> (raw)
In-Reply-To: <20080615124128.48486ddc.krzysztof.h1@poczta.fm>

At Sun, 15 Jun 2008 12:41:28 +0200,
Krzysztof Helt wrote:
> 
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> Use AD1848 register names in the cs4231 library as well.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>

Please fix to be checkpatch.pl clean at the next repost.

WARNING: line over 80 characters
#438: FILE: sound/isa/cs423x/cs4231_lib.c:525:
+		snd_cs4231_dout(chip, AD1848_LEFT_INPUT, chip->image[AD1848_LEFT_INPUT]);
...
total: 0 errors, 60 warnings, 1319 lines checked


thanks,

Takashi

  parent reply	other threads:[~2008-06-19  9:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-15 10:41 [PATCH 2/2] ad1848: replace duplicated constants in cs4231 Krzysztof Helt
2008-06-19  8:31 ` Jaroslav Kysela
2008-06-19  9:11   ` Takashi Iwai
2008-06-19  9:15     ` Jaroslav Kysela
2008-06-19  9:10 ` Takashi Iwai [this message]
2008-06-19 17:56   ` Krzysztof Helt
2008-06-19 18:05     ` Rene Herman
2008-06-20  6:52     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hy75194ev.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=krzysztof.h1@poczta.fm \
    --cc=rene.herman@keyaccess.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox