From: Takashi Iwai <tiwai@suse.de>
To: Dave Dillow <dave@thedillows.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] sis7019: add support for pre-2.6 kernels
Date: Wed, 28 Nov 2007 13:56:03 +0100 [thread overview]
Message-ID: <s5hy7cih6l8.wl%tiwai@suse.de> (raw)
In-Reply-To: <1196255937.7017.57.camel@obelisk.thedillows.org>
At Wed, 28 Nov 2007 08:18:57 -0500,
Dave Dillow wrote:
>
> > Also, replace __ffs() only for 2.4 kernels, e.g.
>
> I'm 50/50 on this -- it doesn't hurt to just use the patched in version,
> even in 2.6. I'm not fond of #ifdefs in code, and I'd need to search for
> when it became available.
But a different code would be compiled even for the same kernel and
with the same config, between alsa-driver and kernel builds.
That's what I'd like to avoid.
> Then again, it is a small patch and the research isn't hard, just a bit
> time consuming.
__ffs() is present on all 2.6 versions. So, >= 2.6.0 should be OK.
thanks,
Takashi
next prev parent reply other threads:[~2007-11-28 13:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 7:19 [PATCH 2/2] sis7019: add support for pre-2.6 kernels Dave Dillow
2007-11-28 9:41 ` Takashi Iwai
2007-11-28 13:18 ` Dave Dillow
2007-11-28 12:56 ` Takashi Iwai [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-12-08 23:54 Dave Dillow
2007-12-10 7:53 ` Clemens Ladisch
2007-12-10 14:24 ` Dave Dillow
2007-12-10 14:48 ` Clemens Ladisch
2007-12-13 15:50 ` Takashi Iwai
2007-12-13 17:43 ` Dave Dillow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy7cih6l8.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dave@thedillows.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox