Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dan Aloni <da-x@monatomic.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: ALC882 on Abit AW9D-MAX
Date: Fri, 20 Apr 2007 13:00:03 +0200	[thread overview]
Message-ID: <s5hy7knwbt8.wl%tiwai@suse.de> (raw)
In-Reply-To: <20070420104946.GA22826@localdomain>

At Fri, 20 Apr 2007 13:49:47 +0300,
Dan Aloni wrote:
> 
> On Wed, Apr 18, 2007 at 02:29:47PM +0200, Takashi Iwai wrote:
> > At Fri, 13 Apr 2007 12:21:51 +0200,
> > I wrote:
> > > 
> > > At Fri, 13 Apr 2007 00:11:41 +0300,
> > > Dan Aloni wrote:
> [...]
> > > > Okay, so based on the 2.6.21-rc6 codebase:
> > > > 
> > > > position_fix=1 fixed the clicks.
> > > > 
> > > > Concerning the speakers - I have found that if I swap the orange
> > > > and black - it works.
> > > 
> > > I had a similar bug report once and it was also an 8-channel device.
> > > Could you try the patch below?
> > 
> > Dan, did you try it?
> 
> I just reverted my own changes and tried your patch - it didn't fix
> the problem.
> 
> From what I figured, for my card (where cfg->line_outs == 4) the code 
> from below should be like this:
> 
>   case 4:
>       if ([Abit-AW9D-MAX ALC822 quirk]) {
>            nid = cfg->line_out_pins[2];
>            cfg->line_out_pins[2] = cfg->line_out_pins[3];
>            cfg->line_out_pins[3] = nid;
>       } else {
>            nid = cfg->line_out_pins[1];
>            cfg->line_out_pins[1] = cfg->line_out_pins[3];
>            cfg->line_out_pins[3] = cfg->line_out_pins[2];
>            cfg->line_out_pins[2] = nid;
>       }
>       break;
> 
> Explanation:
> 
> case 4 originally does {1<=3,3<=2,2<=1}, my working fix effectively 
> adds {1<=2,2<=1}, which means we need to do {1<=1,3<=2,2<=3}, or just
> {3<=2,2<=3}.
> 
> Right?

Sounds so.  Could you attach the content of /proc/asound/card0/codec#*
file to re-check?

thanks,

Takashi

  reply	other threads:[~2007-04-20 11:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070412100959.GA8944@localdomain>
     [not found] ` <s5hmz1dwz2u.wl%tiwai@suse.de>
     [not found]   ` <20070412211141.GA8625@localdomain>
     [not found]     ` <s5hy7kwvakg.wl%tiwai@suse.de>
     [not found]       ` <s5hd521hnlw.wl%tiwai@suse.de>
2007-04-20 10:49         ` ALC882 on Abit AW9D-MAX Dan Aloni
2007-04-20 11:00           ` Takashi Iwai [this message]
2007-04-20 11:13             ` Dan Aloni
2007-04-20 14:28               ` Takashi Iwai
2007-07-09 21:20                 ` Dan Aloni
2007-07-10  9:32                   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hy7knwbt8.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=da-x@monatomic.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox