From: Takashi Iwai <tiwai@suse.de>
To: Jaime Lopez <jsollano@gmail.com>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: Re: [PATCH] Add mixer controls to intel8x0m
Date: Wed, 23 Feb 2005 11:20:21 +0100 [thread overview]
Message-ID: <s5hy8dfshlm.wl@alsa2.suse.de> (raw)
In-Reply-To: <977226cd05022215142133ecc4@mail.gmail.com>
At Tue, 22 Feb 2005 17:14:01 -0600,
Jaime Lopez wrote:
>
> oops. forgot to include the diff:
Please create a unified style patch with diff -u.
Also, don't forget to provide "Signed-off-by" line, too, such as
Signed-off-by: Foo Bar <foo@bar.com>
to add your credit to changelog.
The patch looks almost OK to me (if it works :)
Some points I noticed, though:
- The callback function names can be other ones that match better to
the control itself
- Remove spin_lock_irq() around snd_ac97_*() calls
- Clean up the comments
thanks,
Takashi
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
next prev parent reply other threads:[~2005-02-23 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-22 23:08 [PATCH] Add mixer controls to intel8x0m Jaime Lopez
2005-02-22 23:14 ` Jaime Lopez
2005-02-23 10:20 ` Takashi Iwai [this message]
2005-02-23 15:41 ` Jaime Lopez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy8dfshlm.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@lists.sourceforge.net \
--cc=jsollano@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox