Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Stefan Macher <Stefan.Macher@web.de>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: ALC658 SPDIF input patch
Date: Mon, 10 Jan 2005 13:02:48 +0100	[thread overview]
Message-ID: <s5hy8f1trtj.wl@alsa2.suse.de> (raw)
In-Reply-To: <200501092249.44565.Stefan.Macher@web.de>

At Sun, 9 Jan 2005 22:49:44 +0100,
Stefan Macher wrote:
> 
> Hi,
> 
> I have made a patch to get SPDIF input working with the Realtek ALC658. 
> Realtek has changed the meaning of the Pin47 function selection bit (MX7A bit 
> 1 ) between ALC655 and ALC658.
> 
> ALC655: 0 -> external amplifier power down; 1 -> SPDIF IN
> ALC658: 0 -> SPDIF IN; 1 -> external amplifier power down
> 
> 
> Can please anybody include this into CVS.

The patch looks fine.

Could you provide a signed-off-by line and a brief summary of your
patch to put as a changelog?  The best would be like:

	Summary: Fix blah

	The patch fixes the problem of the driver xxx...

	Signed-off-by: Foo Bar <foo@bar.com>


We need (prefer) to have this for each patch from contributors,
especially for the changes to alsa-kernel tree, which will appear
eventually in the Linux kernel tree.


thanks,

Takashi


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

  reply	other threads:[~2005-01-10 12:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-09 21:49 ALC658 SPDIF input patch Stefan Macher
2005-01-10 12:02 ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-01-10 15:08 Stefan Macher
2005-01-11 13:18 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hy8f1trtj.wl@alsa2.suse.de \
    --to=tiwai@suse.de \
    --cc=Stefan.Macher@web.de \
    --cc=alsa-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox