From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [alsa-devel] [PATCH] ALSA: usb-audio: fix Line6 Helix audio format rates Date: Wed, 03 Jul 2019 10:32:08 +0200 Message-ID: References: <20190702004439.30131-1-nick83ola@gmail.com> <4181a467-5332-c256-5124-513a0343ec70@linux.intel.com> <38462424-4e2b-bdbd-f7cc-ea94385924e0@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <38462424-4e2b-bdbd-f7cc-ea94385924e0@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: "Wasko, Michal" Cc: nick83ola , alsa-devel@alsa-project.org, info@jensverwiebe.de, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Richard Fontana , Jussi Laako , Thomas Gleixner , Allison Randal List-Id: alsa-devel@alsa-project.org On Wed, 03 Jul 2019 10:26:31 +0200, Wasko, Michal wrote: > > >> My idea is that if line6 in the future fixes their code (they are quite active > >> on the helix line) the call will not fail and we get a proper device without > >> quirks. > >> But If the driver fail to get the clock this settings works as a "failsafe" > >> and get the device working. > >> I also tried to contact their support but they don't care a lot about Linux > >> for now :-( > > The fallback might be good, but I'm not sure whether there are many > > devices that hit the same problem. If we encounter more, let's try to > > make it as a fallback. > > thanks, > > > > Takashi > Since there is a chance that the issue will be addressed in USB device FW > thanthe fallback mechanism will make sense. It would cover eventual future > scenario withdevices that will have the issue fixed. Fair enough. Let's handle it as fallback, then. thanks, Takashi