From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ASoC: cs43130: Fix unused compiler warnings for PM runtime
Date: Mon, 04 Sep 2017 15:52:25 +0200 [thread overview]
Message-ID: <s5hziaapo4m.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170904131445.32438-2-tiwai@suse.de>
On Mon, 04 Sep 2017 15:14:45 +0200,
Takashi Iwai wrote:
>
> Add __maybe_unused prefix for addressing the following warnings:
> sound/soc/codecs/cs43130.c:2615:12: warning: ‘cs43130_runtime_resume’ defined but not used [-Wunused-function]
> sound/soc/codecs/cs43130.c:2596:12: warning: ‘cs43130_runtime_suspend’ defined but not used [-Wunused-function]
>
> Fixes: 8f1e5bf9b440 ("ASoC: cs43130: Add support for CS43130 codec")
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Scratch this one, I obviously put to a wrong line.
Will resubmit. Sorry for the inconvenience!
Takashi
> ---
> sound/soc/codecs/cs43130.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/cs43130.c b/sound/soc/codecs/cs43130.c
> index 3fe3b8d644b7..66bc2ec8ff26 100644
> --- a/sound/soc/codecs/cs43130.c
> +++ b/sound/soc/codecs/cs43130.c
> @@ -2563,7 +2563,7 @@ static int cs43130_i2c_probe(struct i2c_client *client,
> return ret;
> }
>
> -static int cs43130_i2c_remove(struct i2c_client *client)
> +static int __maybe_unused cs43130_i2c_remove(struct i2c_client *client)
> {
> struct cs43130_private *cs43130 = i2c_get_clientdata(client);
>
> @@ -2597,7 +2597,7 @@ static int cs43130_i2c_remove(struct i2c_client *client)
> return 0;
> }
>
> -static int cs43130_runtime_suspend(struct device *dev)
> +static int __maybe_unused cs43130_runtime_suspend(struct device *dev)
> {
> struct cs43130_private *cs43130 = dev_get_drvdata(dev);
>
> --
> 2.14.1
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2017-09-04 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 13:14 [PATCH 1/2] ASoC: cs43130: Fix possible Oops with invalid dev_id Takashi Iwai
2017-09-04 13:14 ` [PATCH 2/2] ASoC: cs43130: Fix unused compiler warnings for PM runtime Takashi Iwai
2017-09-04 13:52 ` Takashi Iwai [this message]
2017-09-04 14:49 ` Applied "ASoC: cs43130: Fix possible Oops with invalid dev_id" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hziaapo4m.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox