From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 0/2] ALSA: dice: fix a fatal bug when no
	sound card is registered
Date: Mon, 28 Mar 2016 09:36:11 +0200
Message-ID: <s5hzitj6olw.wl-tiwai@suse.de>
References: <1458993959-22637-1-git-send-email-o-takashi@sakamocchi.jp>
 <56F8696B.8000704@sakamocchi.jp>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 82587260511
 for <alsa-devel@alsa-project.org>; Mon, 28 Mar 2016 09:36:11 +0200 (CEST)
In-Reply-To: <56F8696B.8000704@sakamocchi.jp>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de, ffado-devel@lists.sf.net
List-Id: alsa-devel@alsa-project.org

On Mon, 28 Mar 2016 01:14:51 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On Mar 26 2016 21:05, Takashi Sakamoto wrote:
> > Hi,
> > 
> > This patchset is for Linux 4.6-rc2.
> > 
> > ALSA dice driver causes kernel NULL pointer dereference in a case that
> > no sound card instance is registered and unit is going to be removed.
> > This is observed when dice-based units are connected to Linux system and
> > disconnected within 2 seconds, thus it's rare.
> > 
> > Additionally, even if the bug is fixed, the driver dumps warnings for
> > most dice-based models which supports a pair of isochronous streams.
> > This can occur regardless of the former bug. Users can see this for
> > unsupported dice-based models.
> > 
> > This patchset fixes these bugs.
> 
> I realized that this patchset is not proper to Linux 4.6-rc2. The stream
> data is confirmed to initialized in unit probe callback, and safely
> released when releasing private data. I worked on the other branch and
> had a confusion. So please drop this.
> 
> However, current ALSA dice driver has a bug not to release stream data
> when releasing private data. This causes memory leak and should be fixed
> in 4.6-rc2. I'll post a patch for the bug soon.

So, I don't need to pick up this patchset after applying your fix
([PATCH v2] ALSA: dice: fix memory leak when unplugging)?


thanks,

Takashi