Re: [PATCH V2 6/6] alsabat: add tinyalsa support

[Takashi Iwai <tiwai@suse.de>]

On Tue, 22 Mar 2016 15:31:38 +0100,
han.lu@intel.com wrote:
> 
> diff --git a/bat/alsabat.1 b/bat/alsabat.1
> index 5f41669..9b969c2 100644
> --- a/bat/alsabat.1
> +++ b/bat/alsabat.1
> @@ -33,6 +33,9 @@ analog loopback :-
>  
>  https://source.android.com/devices/audio/loopback.html
>  
> +If tinyalsa lib is installed in system, ALSABAT will use tinyalsa lib instead
> +of ALSA lib.
> +

This text doesn't match with the behavior of your latest version.
Forgot to update?


> diff --git a/configure.ac b/configure.ac
> index d712872..bd39c6f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -58,6 +58,16 @@ AM_CONDITIONAL(HAVE_UCM, test "$have_ucm" = "yes")
>  AM_CONDITIONAL(HAVE_TOPOLOGY, test "$have_topology" = "yes")
>  AM_CONDITIONAL(HAVE_SAMPLERATE, test "$have_samplerate" = "yes")
>  
> +dnl Use tinyalsa
> +tinyalsa=
> +AC_ARG_ENABLE(tinyalsa,
> +    AS_HELP_STRING([--disable-tinyalsa], [Use tinyalsa instead of ALSA]),
> +    [case "${enableval}" in
> +      yes) tinyalsa=true ;;
> +      no) tinyalsa=false ;;
> +      *) AC_MSG_ERROR(bad value ${enableval} for --enable-tinyalsa) ;;
> +    esac],[tinyalsa=false])

This doesn't look consistent.  The default is false while the
description shows --disable-tinyalsa.


thanks,

Takashi