From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: Fw:  [Bug 1155202] [Intel DZ77SL-50K,
	Intel PantherPoint HDMI, Digital Out, HDMI] No sound at all
Date: Mon, 10 Feb 2014 18:27:09 +0100
Message-ID: <s5hzjly98uq.wl%tiwai@suse.de>
References: <52ef1e8f.a4c3440a.53f1.fffff564SMTPIN_ADDED_BROKEN@mx.google.com>
 <CACWODjSKJ7yy6dvH3iCiHLvFgYokgmeSy06mYyGnX4N5JKtkEg@mail.gmail.com>
 <s5hd2ivs5nm.wl%tiwai@suse.de>
 <CACWODjR3HFTFh5iGGS0WZapL7d+kSqiYf=O7QsQu=7dAqQ7TLA@mail.gmail.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 57ACB2625E6
 for <alsa-devel@alsa-project.org>; Mon, 10 Feb 2014 18:27:09 +0100 (CET)
In-Reply-To: <CACWODjR3HFTFh5iGGS0WZapL7d+kSqiYf=O7QsQu=7dAqQ7TLA@mail.gmail.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: niraj kulkarni <kulkarniniraj14@gmail.com>
Cc: alsa-devel@alsa-project.org, David Henningsson <david.henningsson@canonical.com>
List-Id: alsa-devel@alsa-project.org

At Mon, 10 Feb 2014 17:10:16 +0530,
niraj kulkarni wrote:
> 
> Sorry, I did not see that part earlier. Putting udelay(2) is also working
> fine.

OK, thanks for testing.  I'm going to test the patch with other
machines and then merge to the upstream.


Takashi

> 
> Niraj
> 
> 
> On Mon, Feb 10, 2014 at 2:31 PM, Takashi Iwai <tiwai@suse.de> wrote:
> 
> > At Mon, 10 Feb 2014 11:35:41 +0530,
> > niraj kulkarni wrote:
> > >
> > > Removing these 3 usleep ranges is working now. Although I have a doubt
> > for
> > > applying this patch on all chips. There have been a number of boards
> > > released after this particular board, but nobody else is facing this
> > > problem. Since spec does not specify a max on deasserting RST, some
> > boards
> > > might actually take more than 100uS to reset. Will this patch work for
> > > those boards?
> > >
> > > @@ -1149,7 +1149,7 @@
> > >         timeout = jiffies + msecs_to_jiffies(100);
> > >         while ((azx_readb(chip, GCTL) & ICH6_GCTL_RESET) &&
> > >                         time_before(jiffies, timeout))
> > > -               usleep_range(500, 1000);
> > > +               cpu_relax();
> > >  }
> > >
> > >  /* exit link reset */
> > > @@ -1162,7 +1162,7 @@
> > >         timeout = jiffies + msecs_to_jiffies(100);
> > >         while (!azx_readb(chip, GCTL) &&
> > >                         time_before(jiffies, timeout))
> > > -               usleep_range(500, 1000);
> > > +               cpu_relax();
> > >  }
> > >
> > >  /* reset codec link */
> > > @@ -1180,7 +1180,7 @@
> > >         /* delay for >= 100us for codec PLL to settle per spec
> > >          * Rev 0.9 section 5.5.1
> > >          */
> > > -       usleep_range(500, 1000);
> > > +       //usleep_range(500, 1000);
> >
> > Why didn't you change as I suggested?  In my patch, I placed udelay(2)
> > since the spec tells so.  Didn't it interfere?
> >
> > Replacing usleep_range() with cpu_relax() should make still working on
> > other boards because it doesn't change the length of the timeout
> > itself.  The timeout is set to very long (100ms).  The only drawback
> > would be a higher CPU usage at probing, but the impact should be
> > negligible.
> >
> >
> > Takashi
> >
> [2  <text/html; ISO-8859-1 (quoted-printable)>]
>