From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: wrong print debugging message code Date: Mon, 23 Jun 2008 14:13:19 +0200 Message-ID: References: <280b69ac0806202244s11e74363l4de3f020fed849be@mail.gmail.com> <20080623111228.GA9318@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 3424F103878 for ; Mon, 23 Jun 2008 14:13:20 +0200 (CEST) In-Reply-To: <20080623111228.GA9318@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Jin-Young Park List-Id: alsa-devel@alsa-project.org At Mon, 23 Jun 2008 12:12:28 +0100, Mark Brown wrote: > > On Mon, Jun 23, 2008 at 12:55:57PM +0200, Takashi Iwai wrote: > > > The confusing thing is that it defines to '0' (and I'm not sure the > > debug is activated as default in the current code -- Mark, Liam, is it > > intentional?). > > I doubt it. > > > IMO, the debug should be basically off as default, and if enabled, it > > should be defined to '1'. > > Really they should all just be deleted and replaced by the standard > pr_() macros but if we wait for v2 then we'd be able to use the dev_() > variants instead. It depends on your plan. Definitely nice to fix it for 2.6.27, though. Takashi