From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [Pkg-alsa-devel] Bug#438118: alsa-utils: aplay
	non-blocking mode isn't working
Date: Tue, 18 Sep 2007 17:45:24 +0200
Message-ID: <s5hzlzkrn8r.wl%tiwai@suse.de>
References: <20070816.094636.-753684517.anders@netinsight.se>
	<20070911160811.GD17585@frodo.home.lxtec.de>
	<s5hsl5dco8l.wl%tiwai@suse.de>
	<20070918.094148.-529052212.anders@netinsight.se>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id 002112450B
	for <alsa-devel@alsa-project.org>;
	Tue, 18 Sep 2007 17:45:26 +0200 (CEST)
In-Reply-To: <20070918.094148.-529052212.anders@netinsight.se>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Anders =?ISO-8859-1?Q?Bostr=F6m?= <anders@netinsight.net>
Cc: alsa-devel@alsa-project.org, 438118@bugs.debian.org
List-Id: alsa-devel@alsa-project.org

At Tue, 18 Sep 2007 09:41:48 +0200 (CEST),
Anders Bostr=F6m wrote:
> =

> >>>>> "TI" =3D=3D Takashi Iwai <tiwai@suse.de> writes:
> =

> Hi!
> =

>  >> Hi all,
>  >> =

>  >> can one please have a lokk at this? aplay -N isn't working for the
>  >> OP.
> =

>  TI> Cannot reproduce here.  Could you _post_ more details?
> =

> OK, I've tested more, and discovered that the problem seems to be that
> the end of the sound is cut in non-blocking mode. And if I play a very
> short sound-file, I can't hear anything. Blocking mode works fine.
> =

> When using non-blocking mode, an strace contains "ioctl(4, 0x4144,
> 0x2b9f785d8000)        =3D -1 EAGAIN (Resource temporarily
> unavailable)". Blocking mode never contains the EAGAIN response.
> =

> I attach two files. When playing halt.au, I can only hear the start,
> about as much as "ha". When playing metal.au, I can't hear anything.

OK, thanks, I see the problem now.

I don't remember whether it's a feature or a bug.  The drain ioctl
rejects the non-block mode.

Anyway, a simple patch is below.  Let me know if it works.


Takashi

diff -r 0028e39ead78 core/pcm_native.c
--- a/core/pcm_native.c	Tue Sep 18 00:52:38 2007 +0200
+++ b/core/pcm_native.c	Tue Sep 18 17:44:31 2007 +0200
@@ -1368,8 +1368,6 @@ static int snd_pcm_prepare(struct snd_pc
 =

 static int snd_pcm_pre_drain_init(struct snd_pcm_substream *substream, int=
 state)
 {
-	if (substream->f_flags & O_NONBLOCK)
-		return -EAGAIN;
 	substream->runtime->trigger_master =3D substream;
 	return 0;
 }