Re: [PATCH] reenable MIDI for usx2y

[Takashi Iwai <tiwai@suse.de>]

At Wed, 30 Mar 2005 15:49:27 +0200 (CEST),
karsten wiese wrote:
> 
> 
> --- Takashi Iwai <tiwai@suse.de> wrote:
> > At Sun, 27 Mar 2005 14:00:12 +0200 (CEST),
> > karsten wiese wrote:
> > > 
> > > Hi Clemens,
> > > 
> > > usx2y needs to specify exactly what usb-endpoints to
> > use.
> > > this feature got lost lately and is restored by
> > attached
> > > patch. Please apply!
> > 
> > IMO, it's better to fix snd_usbmidi_detect_endpoints() to
> > check
> > in_ep and out_ep rather than its caller.
> 
> I'd prefer a new function snd_usbmidi_check_endpoints()
> then.
> Caller would call snd_usbmidi_check_endpoints() if
> ep_out/ep_in would be set by client and would call
> snd_usbmidi_detect_endpoints() in the other case.
> How about that?

Hmm, I thought the old code detects in/out endpoints if they are NULL.
That is, if out_ep == NULL and in_ep != NULL, out_ep is detected but
in_ep is used as it is.

If this isn't the case, checking in the caller side seems OK.


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click