Re: [PATCH] azx/realtek: Unify and parameterize code for ALC880/260 codecs, take 2

[Takashi Iwai <tiwai@suse.de>]

At Thu, 16 Dec 2004 13:11:06 -0800,
Stephen Warren wrote:
> 
> This patch updates the HD-Audio ALC880/260 code driver such
> that all board-specific decisions are made in a single function,
> which sets variables that all other code simply uses directly
> without decision making.
> 
> Also, tweak snd_hda_add_new_ctls and snd_hda_resume_ctls so they
> use a sentinel value in the array of controls, and hence don't have
> to be passed an explicit array-size argument.
> 
> This has the benefits of:
> 
> * Isolating board-specific code to a single location
> * Simplifying the rest of the code
> * Unifying the code for ALC880/ALC260, which was previously separate.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> 
> Note: This patch was generated by "cvs diff -u". Hopefully, that's a
> useful format - there are some extra lines of gunk that single-file
> regular "diff -u" doesn't generate...

Thanks for the patch.  That's no problem.  Patch is clever enough ;)

> This is an updated version of the patch I sent yesterday, that also
> tweaks the tweak snd_hda_add_new_ctls/snd_hda_resume_ctls API.
> 
> For now, I think I'm done with generic changes to the AZX codec, so the
> patch is complete, unless you find any problems with it.

I applied to CVS now.  Additionally, I put new comments about the
array termination for snd_hda_add_new_ctls() and
snd_hda_resume_ctls().

> 
> I'm punting on making patch_alc880/260 use pre-initialized data
> structures for codec->spec for now - the code isn't too hairy yet, and
> it'll be something very easily added later on if we decide to do it.

This sounds nice.

Also, we can merge many codes between patch_realtek.c and
patch_cmedia.c.  It would help for codecs from other vendors in
future.


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/