From: huangwenhui <huangwenhuia@uniontech.com>
To: "Takashi Iwai" <tiwai@suse.de>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
kailang <kailang@realtek.com>,
tanureal <tanureal@opensource.cirrus.com>,
"jeremy.szu" <jeremy.szu@canonical.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
tiwai <tiwai@suse.com>, wse <wse@tuxedocomputers.com>,
"hui.wang" <hui.wang@canonical.com>, sami <sami@loone.fi>,
cam <cam@neo-zeon.de>
Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671
Date: Fri, 11 Mar 2022 16:51:38 +0800 [thread overview]
Message-ID: <tencent_1FFDCEAB776DE8D712987685@qq.com> (raw)
In-Reply-To: <s5ho82cevra.wl-tiwai@suse.de>
I will modify the patch and commit again.
Thanks.
------------------ Original ------------------
From: "Takashi Iwai"<tiwai@suse.de>;
Date: Fri, Mar 11, 2022 04:30 PM
To: "huangwenhui"<huangwenhuia@uniontech.com>;
Cc: "perex"<perex@perex.cz>; "tiwai"<tiwai@suse.com>; "jeremy.szu"<jeremy.szu@canonical.com>; "hui.wang"<hui.wang@canonical.com>; "wse"<wse@tuxedocomputers.com>; "cam"<cam@neo-zeon.de>; "kailang"<kailang@realtek.com>; "tanureal"<tanureal@opensource.cirrus.com>; "sami"<sami@loone.fi>; "alsa-devel"<alsa-devel@alsa-project.org>; "linux-kernel"<linux-kernel@vger.kernel.org>;
Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671
On Fri, 11 Mar 2022 02:20:42 +0100,
huangwenhui wrote:
>
> Hi Takashi,
>
> if adjusting the mixer element or replugging the headset, the headphone would
> be unmuted.
> But most users hope that the default state is unmuted.
> Should this unconditional unmute be required?
It's the standard behavior for most of ALSA drivers.
The initial mute state is rather controlled via alsactl, restoring the
previous state. Also, the sound server like PulseAudio or pipewire
does unmute automatically. If this doesn't work as expected, that's a
more problem to diagnose.
Takashi
>
> Thanks.
>
> ------------------ Original ------------------
> From: "Takashi Iwai"<tiwai@suse.de>;
> Date: Thu, Mar 10, 2022 10:03 PM
> To: "huangwenhui"<huangwenhuia@uniontech.com>;
> Cc: "perex"<perex@perex.cz>; "tiwai"<tiwai@suse.com>; "jeremy.szu"
> <jeremy.szu@canonical.com>; "hui.wang"<hui.wang@canonical.com>; "wse"
> <wse@tuxedocomputers.com>; "cam"<cam@neo-zeon.de>; "kailang"
> <kailang@realtek.com>; "tanureal"<tanureal@opensource.cirrus.com>; "sami"
> <sami@loone.fi>; "alsa-devel"<alsa-devel@alsa-project.org>; "linux-kernel"
> <linux-kernel@vger.kernel.org>;
> Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP
> machine with alc671
>
> On Thu, 10 Mar 2022 14:58:36 +0100,
> huangwenhui wrote:
> >
> > Hi Takashi,
> >
> > Thank you for your reply.
> >
> > When booting with plugged headset, the headphone will be muted.
>
> The muted state is the default behavior. Wouldn't it be unmuted if
> you adjust the corresponding mixer element?
>
> Takashi
>
> >
> > Thanks.
> >
> > ------------------ Original ------------------
> > From: "Takashi Iwai"<tiwai@suse.de>;
> > Date: Thu, Mar 10, 2022 09:29 PM
> > To: "huangwenhui"<huangwenhuia@uniontech.com>;
> > Cc: "perex"<perex@perex.cz>; "tiwai"<tiwai@suse.com>; "jeremy.szu"
> > <jeremy.szu@canonical.com>; "hui.wang"<hui.wang@canonical.com>; "wse"
> > <wse@tuxedocomputers.com>; "cam"<cam@neo-zeon.de>; "kailang"
> > <kailang@realtek.com>; "tanureal"<tanureal@opensource.cirrus.com>; "sami"
> > <sami@loone.fi>; "alsa-devel"<alsa-devel@alsa-project.org>; "linux-kernel"
> > <linux-kernel@vger.kernel.org>;
> > Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP
> > machine with alc671
> >
> > On Thu, 10 Mar 2022 14:03:01 +0100,
> > huangwenhui wrote:
> > >
> > > On a HP 288 Pro G8, the front Mic could not be detected.
> > >
> > > Signed-off-by: huangwenhui <huangwenhuia@uniontech.com>
> >
> > Thanks for the patch. Most of the changes look OK, but one thing I
> > still don't get:
> >
> > > + case HDA_FIXUP_ACT_INIT:
> > > + alc_write_coef_idx(codec, 0x19, 0xa054);
> > > + msleep(80);
> > > + snd_hda_codec_write(codec, hp_pin, 0,
> > > + AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE);
> >
> > Why this unconditional unmute is required for fixing the mic problem?
> >
> > Takashi
> >
> >
>
>
next prev parent reply other threads:[~2022-03-14 7:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 1:20 [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671 huangwenhui
2022-03-11 8:30 ` Takashi Iwai
2022-03-11 8:51 ` huangwenhui [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-12 9:22 Meng Tang
2022-07-12 9:31 ` Takashi Iwai
2022-03-11 9:38 huangwenhui
2022-03-11 16:05 ` Takashi Iwai
2022-03-10 13:03 huangwenhui
2022-03-10 13:29 ` Takashi Iwai
2022-03-10 13:58 ` 黄文辉
2022-03-10 14:02 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_1FFDCEAB776DE8D712987685@qq.com \
--to=huangwenhuia@uniontech.com \
--cc=alsa-devel@alsa-project.org \
--cc=cam@neo-zeon.de \
--cc=hui.wang@canonical.com \
--cc=jeremy.szu@canonical.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sami@loone.fi \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox